Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Retries Can Fail Because Cluster Metadata Exists #87

Closed
dgoodwin opened this issue Nov 19, 2018 · 5 comments
Closed

Install Retries Can Fail Because Cluster Metadata Exists #87

dgoodwin opened this issue Nov 19, 2018 · 5 comments

Comments

@dgoodwin
Copy link
Contributor

Currently we're failing to update status after install (separate issue), but in this case the cluster metadata got uploaded, and install re-tries fail as a result here.

@dgoodwin
Copy link
Contributor Author

Admin kubeconfig too.

@joelddiaz
Copy link
Contributor

What do we do in the case where there is an existing configmap/secret? Trash/replace?

@dgoodwin
Copy link
Contributor Author

I think they fall into the same bucket as the cleanup before install, so yeah I'd trash them if they exist and we're runinng a new install job.

@joelddiaz
Copy link
Contributor

after discussion the plan is to:

  1. detect any pre-existing secret/configmap and delete
  2. 10 retries to fetch/store the admin kubeconfig (this is considered a critical failure)
  3. best effort to save the installer's metadata file
  4. update the clusterdeployment status with the secret name holding the admin kubeconfig (non-critical as it will be updated during normal controller reconciliation)

@joelddiaz
Copy link
Contributor

fixed with #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants