Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsphere creds checking #1186

Merged
merged 3 commits into from Dec 4, 2020
Merged

vsphere creds checking #1186

merged 3 commits into from Dec 4, 2020

Commits on Dec 1, 2020

  1. vsphere creds checking 

    Fix the immediate problem where passing bad credentials for a vSphere installation means that deleting the ClusterDeployment doesn't get deleted (b/c the deprovision fails (b/c of the bad creds)).

Test the creds, and set a condition so that we can avoid ever even creating a ClusterProvision when we detect bad credentials. This means deprovision works b/c the provision was never attempted. Right now we only check vSphere credentials, but more platforms can (and should) be added.

Add test cases to validate this.
    @abutcher
    Joel Diaz authored and abutcher committed Dec 1, 2020
    Copy the full SHA
    58fe555 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Return error when credentials fail validation.

    @abutcher
    abutcher committed Dec 2, 2020
    Copy the full SHA
    c743702 View commit details
    Browse the repository at this point in the history

  2. Add condition to provision_underway_collector.go

    @abutcher
    abutcher committed Dec 2, 2020
    Copy the full SHA
    9b650c3 View commit details
    Browse the repository at this point in the history