remove VPC endpoints #122
Merged
remove VPC endpoints #122
+36
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
@dak1n1 looks like some new perms for openshift/installer#444 |
dgoodwin
reviewed
Dec 4, 2018
| logger.Infof("Deleted route %v from route table %v", *route.DestinationCidrBlock, *rt.RouteTableId) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Should we keep this code even if it's been replaced in installer so that hiveutil remains able to uninstall clusters even created prior to this? Maybe just document why and keep it for a few months?
There was a problem hiding this comment.
From what I've seen, removing individual routes from a route table is not needed to remove the route table. So it's really just uneccessary API calls to empty the route table before deleting the route table, when all we need is to delete the route table directly.
installer wants to start using VPC endpoints (openshift/installer#745), so the uninstaller should find and remove them (they are untaggable objects) also, remove the code that would remove the individual routes from a route table (it's not needed to remove routes to be able to delete RouteTables) needed to add these permissions to get the installer/uninstaller working: ec2:DescribePrefixLists ec2:DescribeVpcEndpoints ec2:CreateVpcEndpoint ec2:DeleteVpcEndpoints
joelddiaz
force-pushed
the
delete-vpc-endpoints
branch
from
63f6e5d
to
b7d7151
Compare
|
/lgtm |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Dec 13, 2018
Pulling in openshift/hive@b7d71518 (remove VPC endpoints, 2018-12-03, openshift/hive#122). Generated with: $ sed -i s/2349f175d3e4fc6542dec79add881a59f2d7b1b8/802db5420da6a88f034fc2501081e2ab12e8463e/ Gopkg.toml $ dep ensure using: $ dep version dep: version : v0.5.0 build date : git hash : 22125cf go version : go1.10.3 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Dec 13, 2018
Pulling in openshift/hive@b7d71518 (remove VPC endpoints, 2018-12-03, openshift/hive#122). Generated with: $ sed -i s/2349f175d3e4fc6542dec79add881a59f2d7b1b8/802db5420da6a88f034fc2501081e2ab12e8463e/ Gopkg.toml $ dep ensure using: $ dep version dep: version : v0.5.0 build date : git hash : 22125cf go version : go1.10.3 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installer wants to start using VPC endpoints (openshift/installer#745), so the uninstaller should find and remove them (they are untaggable objects)
also, remove the code that would remove the individual routes from a route table (it's not needed to remove routes to be able to delete RouteTables)
needed to add these permissions to get the installer/uninstaller working:
ec2:DescribePrefixLists
ec2:DescribeVpcEndpoints
ec2:CreateVpcEndpoint
ec2:DeleteVpcEndpoints