Change fake-cluster-id to a real uuid #1270
Conversation
- [x] Change fake-cluster-id to a real uuid - [x] Test the change to ensure it is working correctly
openshift-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelddiaz, twiest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| installertypes "github.com/openshift/installer/pkg/types" | ||
|
|
||
| hivev1 "github.com/openshift/hive/pkg/apis/hive/v1" | ||
| ) | ||
|
|
||
| const fakeMetadataFormatStr = `{"aws":{"identifier":[{"kubernetes.io/cluster/fake-infraid":"owned"},{"openshiftClusterID":"fake-cluster-id"}],"region":"us-east-1"},"clusterID":"fake-cluster-id","clusterName":"%s","infraID":"fake-infra-id"}` | ||
| const fakeMetadataFormatStr = `{"aws":{"identifier":[{"kubernetes.io/cluster/fake-infraid":"owned"},{"openshiftClusterID":"%s"}],"region":"us-east-1"},"clusterID":"%s","clusterName":"%s","infraID":"fake-infra-id"}` |
There was a problem hiding this comment.
I think the goal of using fake-cluster-id was to make it sure clear that this is a fake cluster, replacing this with UUID only now makes these clusters look very similar to real ones which can cause problems.. any reason why we didn't go for the original recommendation from slack thread of fake-cluster-UUID @twiest
There was a problem hiding this comment.
For posterity, this pattern was discussed on slack, but didn't make it to the card. Working on a separate PR to change to using this pattern.
/assign @joelddiaz
/cc @suhanime