vendor: bump installer to latest #1272
Conversation
go.mod
Outdated
| // from installer | ||
| // Prevent the following modules from upgrading version as result of terraform-provider-kubernetes module | ||
| // The following modules need to be locked to compile correctly with terraform-provider-azure and terraform-provider-google | ||
| replace ( | ||
| github.com/Azure/go-autorest/autorest/adal => github.com/Azure/go-autorest/autorest/adal v0.8.2 | ||
| github.com/Azure/go-autorest/autorest/azure/cli => github.com/Azure/go-autorest/autorest/azure/cli v0.3.1 | ||
| github.com/Azure/go-autorest/autorest/date => github.com/Azure/go-autorest/autorest/date v0.2.0 | ||
| github.com/Azure/go-autorest/autorest/validation => github.com/Azure/go-autorest/autorest/validation v0.2.1-0.20191028180845-3492b2aff503 | ||
| github.com/apparentlymart/go-cidr => github.com/apparentlymart/go-cidr v1.0.1 | ||
| github.com/go-openapi/spec => github.com/go-openapi/spec v0.19.0 | ||
| github.com/googleapis/gnostic => github.com/googleapis/gnostic v0.4.1 | ||
| github.com/hashicorp/go-plugin => github.com/hashicorp/go-plugin v1.2.2 | ||
| github.com/ulikunitz/xz => github.com/ulikunitz/xz v0.5.7 | ||
| google.golang.org/api => google.golang.org/api v0.25.0 | ||
| google.golang.org/genproto => google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013 | ||
| google.golang.org/grpc => google.golang.org/grpc v1.29.1 | ||
| ) |
There was a problem hiding this comment.
This is way better - I wonder if this warranties some changes here
There was a problem hiding this comment.
this is one off change we need to replace because of openshift/installer#4350 , i think this should be removed when installer bumps to set of dependencies that don't need this specifically.
the doc provides general guidelines of how to add or update the dependencies in most/usual case, like the cluster-api vendor bumps for aws etc included here too in the original replace block
|
I wonder if master should use a forked version of installer as well |
installer changed its machine api v1beta1 import paths in [1]. Also openstack updated it's platform to deprecate the machine flavorName (keeping the marshalled api the same), and also removed an options from MachineSet generator function [1]: openshift/installer@b0b9646
abhinavdahiya
force-pushed
the
installer-bump-latest
branch
from
fcfdafb
to
dc89529
Compare
previously in the installer repo we used always tried to use upstream directly as much as possible and use the forks when we need some changeset which not in any supported tips(branches). So personally i would not recommend using the fork unless required. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, suhanime The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
bumps the installer vendor to latest, also updates the code to work with new vendor
xref: https://issues.redhat.com/browse/HIVE-1354
/assign @dgoodwin
/cc @suhanime