AWS PrivateLink: "Spread" VPC endpoints across VPCs #1744
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
|
openshift-ci
bot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #1744 +/- ##
==========================================
- Coverage 41.76% 41.74% -0.03%
==========================================
Files 346 346
Lines 32118 32106 -12
==========================================
- Hits 13415 13403 -12
Misses 17583 17583
Partials 1120 1120
|
Since we don't know the actual quota of endpoints per VPC, create new endpoints in the least-used VPC. The result should be that we hit quota only when all the VPCs are full. HIVE-1803
We had logic to filter out VPCs based on a hardcoded maximum number of allowed endpoints. That limit is actually based on a (changeable) quota set by AWS. In the future we may attempt to discover that quota and reinstate the filter; but for now simply remove it. HIVE-1803
Fix some yellow squiggly lines in VSCode.
2uasimojo
force-pushed
the
HIVE-1803/vpc-limits
branch
from
001a609
to
875d3ac
Compare
|
/assign @abutcher |
2uasimojo
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, abutcher The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since we don't know the actual quota of endpoints per VPC, remove the arbitrary limit check, and create new endpoints in the least-used VPC. The result should be that we hit quota only when all the VPCs are full.
HIVE-1803