Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: increase targetNamespace timeout 30s=>3m #1799

Merged
merged 1 commit into from Jun 17, 2022
Merged

e2e: increase targetNamespace timeout 30s=>3m #1799

merged 1 commit into from Jun 17, 2022

Conversation

2uasimojo
Copy link
Member

30s wasn't a reasonable amount of time to expect to get all the way from
Deployment to a completed reconcile loop, and we've been seeing a lot of
CI flakes as a result.

@2uasimojo
e2e: increase targetNamespace timeout 30s=>3m
44a4b16 
30s wasn't a reasonable amount of time to expect to get all the way from
Deployment to a completed reconcile loop, and we've been seeing a lot of
CI flakes as a result.
@2uasimojo
Copy link
Member Author

/assign @abutcher

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
@2uasimojo
Copy link
Member Author

cc @abraverm -- this was probably the cause of all those flakes you started seeing.

@abutcher
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, abutcher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2uasimojo
Copy link
Member Author

/test e2e

but this looks like it might be real?

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD f9e6e20 and 8 for PR HEAD 44a4b16 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2022

@2uasimojo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-pool 44a4b16 link true /test e2e-pool
ci/prow/e2e 44a4b16 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@2uasimojo
Copy link
Member Author

Force-merging this so #1802 can land (and unwedge CI) without annoying flakes.

@2uasimojo 2uasimojo merged commit 411bb71 into openshift:master Jun 17, 2022
@2uasimojo 2uasimojo deleted the e2e-timeout branch June 17, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhil-rane akhil-rane Awaiting requested review from akhil-rane

@suhanime suhanime Awaiting requested review from suhanime

Assignees

@abutcher abutcher

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@2uasimojo @abutcher @openshift-ci-robot