Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clustersyncfailing metric to crd #1814

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

suhanime
Copy link
Contributor

@suhanime suhanime commented Jul 1, 2022

While adding ClusterSyncFailingSeconds metric, adding it to the enum in
durationMetrics was missed, which didn't catch the appropriate make
targets for adding it to the crd. This commit fixes that.

xref: https://issues.redhat.com/browse/HIVE-1857

/assign @2uasimojo

While adding ClusterSyncFailingSeconds metric, adding it to the enum in
durationMetrics was missed, which didn't catch the appropriate make
targets for adding it to the crd. This commit fixes that.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2022
Copy link
Member

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah. Sorry I missed this during review.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2022

@suhanime: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1814 (2484323) into master (98148ea) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1814      +/-   ##
==========================================
- Coverage   41.74%   41.69%   -0.05%     
==========================================
  Files         353      353              
  Lines       33079    33118      +39     
==========================================
  Hits        13810    13810              
- Misses      18113    18151      +38     
- Partials     1156     1157       +1     
Impacted Files Coverage Δ
pkg/controller/machinepool/alibabacloudactuator.go 48.61% <0.00%> (-13.21%) ⬇️
...g/controller/hibernation/hibernation_controller.go 64.97% <0.00%> (-0.37%) ⬇️
pkg/ibmclient/client.go 4.48% <0.00%> (-0.30%) ⬇️
...ller/clusterrelocate/clusterrelocate_controller.go 56.09% <0.00%> (-0.09%) ⬇️
pkg/client/clientset/versioned/clientset.go 0.00% <0.00%> (ø)

@openshift-ci openshift-ci bot merged commit 66d98a5 into openshift:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants