Refactor: Include ClusterProvision in InstallManager #1825
Conversation
In preparation for needing to plumb some data from the ClusterProvision into the invocations of the openshift-install command, add a new field to InstallManager containing the actual ClusterProvision object. This allows us to change a bunch of function prototypes to remove it as an argument, as those functions can get it from the InstallManager argument they already accept (or are methods on). HIVE-1966
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
2uasimojo
added
do-not-merge/hold
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## master #1825 +/- ##
==========================================
- Coverage 41.71% 41.70% -0.01%
==========================================
Files 354 354
Lines 33142 33139 -3
==========================================
- Hits 13824 13822 -2
+ Misses 18155 18154 -1
Partials 1163 1163
|
|
Closing in favor of #1828 |
In preparation for needing to plumb some data from the ClusterProvision
into the invocations of the openshift-install command, add a new field
to InstallManager containing the actual ClusterProvision object. This
allows us to change a bunch of function prototypes to remove it as an
argument, as those functions can get it from the InstallManager argument
they already accept (or are methods on).
HIVE-1966