Explicit pod security

[abutcher]

This PR unreverts #1884 and removes seccompProfile settings from deployments. Versions prior to 4.11 do not have a restricted SCC that allows setting seccompProfile.

HIVE-2023

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abutcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #1885 (785e973) into master (ef13b76) will increase coverage by 0.12%.
Report is 283 commits behind head on master.
The diff coverage is 92.77%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
+ Coverage   42.13%   42.25%   +0.12%     
==========================================
  Files         366      366              
  Lines       33976    34057      +81     
==========================================
+ Hits        14315    14390      +75     
- Misses      18458    18461       +3     
- Partials     1203     1206       +3     

Files Changed	Coverage Δ
pkg/constants/constants.go	100.00% <ø> (ø)
pkg/operator/assets/bindata.go	0.00% <ø> (ø)
.../controller/clusterdeployment/clusterprovisions.go	61.70% <80.00%> (+0.40%)	⬆️
...lusterdeprovision/clusterdeprovision_controller.go	54.27% <80.00%> (+0.99%)	⬆️
.../clusterdeployment/clusterdeployment_controller.go	62.96% <83.33%> (+0.14%)	⬆️
pkg/controller/utils/utils.go	82.19% <100.00%> (+2.71%)	⬆️
pkg/imageset/generate.go	97.53% <100.00%> (+0.03%)	⬆️
pkg/install/generate.go	42.77% <100.00%> (+0.21%)	⬆️
pkg/test/assert/assertions.go	92.30% <100.00%> (+2.30%)	⬆️

[abutcher]

/hold

[abutcher]

Rebased and cleaned up the namespace scraping a little bit. If we go this route, which I currently think we might, we may need to ensure that our PSA/UID settings jive with K8s or possibly skip configuring pod security if we're not on OpenShift.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-ci]

@abutcher: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/periodic-images	785e973	link	true	/test periodic-images
ci/prow/images	785e973	link	true	/test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[2uasimojo]

@dlom was going through some oldymoldy to-dos and came across this, related to https://issues.redhat.com/browse/HIVE-2023

[Later] Oh, I guess it was already linked :)