SDE-2544: Allow setting AWS EC2Metadata in machine config pool #2004
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@tsorya: This pull request references SDE-2544 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@tsorya: This pull request references SDE-2544 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2004 +/- ##
=======================================
Coverage 57.72% 57.72%
=======================================
Files 186 186
Lines 25219 25221 +2
=======================================
+ Hits 14557 14559 +2
Misses 9425 9425
Partials 1237 1237
|
There was a problem hiding this comment.
This looks great @tsorya, thanks!
- Please create a card in the HIVE project
- I think you'll need a
make updateto regenerate that saas template (verifyfailure)
The e2e-pool failure is a flake. (I don't expect this change to affect that test.)
|
|
||
| // EC2MetadataOptions defines metadata service interaction options for EC2 instances in the machine pool. | ||
| // +optional | ||
| EC2Metadata *EC2Metadata `json:"metadataService,omitempty"` |
There was a problem hiding this comment.
Weird json name, but I see you're just matching the one in the installer type 🤷
There was a problem hiding this comment.
Yeah, not mine. I think better to match to installer's
|
@tsorya: This pull request references SDE-2544 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@tsorya: This pull request references SDE-2544 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
lgtm
|
@tsorya: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, tsorya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
SDE-2544: Allow setting AWS EC2Metadata in machine config pool
HIVE-2211