Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google.golang.org/grpc 1.58.3 #2143

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Oct 17, 2023

This may or may not help address the following, found by snyk:

> ✗ High severity vulnerability found in github.com/dgrijalva/jwt-go76 Description: Access Restriction Bypass77 Info: https://security.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMDGRIJALVAJWTGO-59651578 Introduced through: github.com/IBM/networking-go-sdk/dnsrecordsv1@0.14.0, github.com/IBM/networking-go-sdk/zonesv1@0.14.0, github.com/openshift/installer/pkg/asset/machines/ibmcloud@#2c449439afd9, github.com/openshift/installer/pkg/destroy/ibmcloud@#2c449439afd979 From: github.com/IBM/networking-go-sdk/dnsrecordsv1@0.14.0 > github.com/IBM/go-sdk-core/v4/core@4.10.0 > github.com/dgrijalva/jwt-go@3.2.180 From: github.com/IBM/networking-go-sdk/zonesv1@0.14.0 > github.com/IBM/go-sdk-core/v4/core@4.10.0 > github.com/dgrijalva/jwt-go@3.2.181 From: github.com/openshift/installer/pkg/asset/machines/ibmcloud@#2c449439afd9 > github.com/openshift/installer/pkg/asset/installconfig/ibmcloud@#2c449439afd9 > github.com/IBM/networking-go-sdk/zonesv1@0.14.0 > github.com/IBM/go-sdk-core/v4/core@4.10.0 > github.com/dgrijalva/jwt-go@3.2.182 and 1 more...83 Fixed in: 4.0.0-preview1

HIVE-2337
@openshift-ci openshift-ci bot requested review from dlom and jstuever October 17, 2023 22:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@2uasimojo
Copy link
Member Author

/assign @suhanime

@2uasimojo
Copy link
Member Author

security fail still as expected: #2144 (stacked on this) should resolve the last one.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2143 (fbfc248) into master (868c380) will increase coverage by 0.22%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2143      +/-   ##
==========================================
+ Coverage   57.57%   57.79%   +0.22%     
==========================================
  Files         187      187              
  Lines       25839    26000     +161     
==========================================
+ Hits        14876    15026     +150     
- Misses       9718     9726       +8     
- Partials     1245     1248       +3     

see 3 files with indirect coverage changes

@suhanime
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

@2uasimojo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security fbfc248 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 85aad5e into openshift:master Oct 18, 2023
8 of 9 checks passed
@2uasimojo 2uasimojo deleted the HIVE-2337/grcp-vuln branch October 18, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants