Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport various CVE fixes #2150

Merged
merged 4 commits into from
Oct 21, 2023
Merged

Conversation

2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Oct 20, 2023

CVE-2023-45142

(cherry picked from commit 490498c)
(cherry picked from commit cadb550)

Conflicts: Many. Had to walk through the go.mods and then re-tidy/vendor.
(cherry picked from commit 5ea448f)

Conflicts: Many. Had to walk through the go.mods and then re-tidy/vendor.
This may or may not help address the following, found by snyk:

> ✗ High severity vulnerability found in github.com/dgrijalva/jwt-go76 Description: Access Restriction Bypass77 Info: https://security.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMDGRIJALVAJWTGO-59651578 Introduced through: github.com/IBM/networking-go-sdk/dnsrecordsv1@0.14.0, github.com/IBM/networking-go-sdk/zonesv1@0.14.0, github.com/openshift/installer/pkg/asset/machines/ibmcloud@#2c449439afd9, github.com/openshift/installer/pkg/destroy/ibmcloud@#2c449439afd979 From: github.com/IBM/networking-go-sdk/dnsrecordsv1@0.14.0 > github.com/IBM/go-sdk-core/v4/core@4.10.0 > github.com/dgrijalva/jwt-go@3.2.180 From: github.com/IBM/networking-go-sdk/zonesv1@0.14.0 > github.com/IBM/go-sdk-core/v4/core@4.10.0 > github.com/dgrijalva/jwt-go@3.2.181 From: github.com/openshift/installer/pkg/asset/machines/ibmcloud@#2c449439afd9 > github.com/openshift/installer/pkg/asset/installconfig/ibmcloud@#2c449439afd9 > github.com/IBM/networking-go-sdk/zonesv1@0.14.0 > github.com/IBM/go-sdk-core/v4/core@4.10.0 > github.com/dgrijalva/jwt-go@3.2.182 and 1 more...83 Fixed in: 4.0.0-preview1

HIVE-2337

(cherry picked from commit 69f4a9b)
(cherry picked from commit 0445485)

Conflicts: many. Had to manually walk through go.mod and then
re-tidy/vendor.

(cherry picked from commit 9d59988)
Conflicts: many. Had to manually walk through go.mod and then
re-tidy/vendor.
CVE-2023-44487

HIVE-2337

(cherry picked from commit fbfc248)
(cherry picked from commit 181a03f)

Conflicts:
	go.sum

(go mod tidy took care of it)

(cherry picked from commit 0ece0ed)

Conflicts:
	go.sum

(go mod tidy took care of it)
CVE-2023-44487

HIVE-2337

(cherry picked from commit 1c39f65)
(cherry picked from commit 7431546)

Conflicts:
	apis/go.sum
	apis/vendor/modules.txt
	go.mod
	go.sum

Manual edit of go.mod, then go mod tidy/vendor.

(cherry picked from commit 16a86ad)

Conflicts:
	go.sum

`go mod tidy` took care of it
@2uasimojo
Copy link
Member Author

/assign @suhanime

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2150 (027ceee) into mce-2.2 (06a8646) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           mce-2.2    #2150   +/-   ##
========================================
  Coverage    42.17%   42.17%           
========================================
  Files          366      366           
  Lines        34098    34098           
========================================
  Hits         14382    14382           
  Misses       18492    18492           
  Partials      1224     1224           

@suhanime
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit a2eaf71 into openshift:mce-2.2 Oct 21, 2023
7 checks passed
@2uasimojo 2uasimojo deleted the cve-mce-2.2 branch October 23, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants