Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-2518: Vendor cpms to incorporate clean of ResourcePool #2335

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

lleshchi
Copy link
Contributor

No description provided.

Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 26, 2024

@lleshchi: This pull request references HIVE-2518 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from 2uasimojo and dlom June 26, 2024 21:05
Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lleshchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@lleshchi
Copy link
Contributor Author

/assign @celebdor

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.57%. Comparing base (e01288d) to head (bcd32d4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2335   +/-   ##
=======================================
  Coverage   58.57%   58.57%           
=======================================
  Files         182      182           
  Lines       25863    25863           
=======================================
  Hits        15150    15150           
  Misses       9437     9437           
  Partials     1276     1276           

Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

@lleshchi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security bcd32d4 link true /test security
ci/prow/periodic-images bcd32d4 link true /test periodic-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@celebdor
Copy link
Contributor

This fixed the pre-merge testing done by @dtthuynh . It fixed scaling for 4.14.30 and 4.15.18 as well as kept it working for 4.16.0

@celebdor
Copy link
Contributor

Regression testing for other platforms completed by @huangmingxia and @jianping-shu

@celebdor celebdor merged commit b1ac27b into openshift:master Jun 27, 2024
6 of 10 checks passed
@celebdor
Copy link
Contributor

/cherry-pick mce-2.6

@openshift-cherrypick-robot

@celebdor: new pull request created: #2336

In response to this:

/cherry-pick mce-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants