Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrape all KAS metrics inside guest cluster #1421

Merged

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented May 26, 2022

What this PR does / why we need it:
We currently sync a servicemonitor into the guest cluster so that KAS
metrics are scraped by the guest CMO. However, the current
servicemonitor only scrapes a single metric from the KAS.

This commit modifies the servicemonitor so it includes all metrics that
are typically scraped in a standalone OCP cluster.

Checklist

  • Subject and description added to both, commit and PR.

We currently sync a servicemonitor into the guest cluster so that KAS
metrics are scraped by the guest CMO. However, the current
servicemonitor only scrapes a single metric from the KAS.

This commit modifies the servicemonitor so it includes all metrics that
are typically scraped in a standalone OCP cluster.
@openshift-ci openshift-ci bot requested review from enxebre and sjenning May 26, 2022 21:28
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@sjenning
Copy link
Contributor

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 506608b and 8 for PR HEAD 7bf07de in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@csrwng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-nested 7bf07de link false /test e2e-aws-nested
ci/prow/e2e-kubevirt-gcp-ovn 7bf07de link false /test e2e-kubevirt-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 506608b and 7 for PR HEAD 7bf07de in total

@openshift-merge-robot openshift-merge-robot merged commit 1fbe46c into openshift:main Jun 1, 2022
@csrwng csrwng deleted the fix-guest-kas-relabelconfigs branch June 14, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants