Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: HOSTEDCP-587 explain more in detail Public and PublicAndPrivate endpoint-access #1788

Merged
merged 1 commit into from Oct 13, 2022

Conversation

jparrill
Copy link
Contributor

@jparrill jparrill commented Oct 6, 2022

The issue faced here, it's basically that we only had 1 public Hosted Zone, so the external DNS operator tries to publish all the routes because of a Race condition. This ends on an error trying to publish a too large route which is not allowed by Route53

Signed-off-by: Juan Manuel Parrilla Madrid jparrill@redhat.com

What this PR does / why we need it:

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit e5f0f2c
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/633ed43502592d0008437fc3
😎 Deploy Preview https://deploy-preview-1788--hypershift-docs.netlify.app/how-to/external-dns
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…endpoint-access

The issue faced here, it's bassically that we only had 1 public Hosted Zone, so the external DNS operator tries to publish all the routes because of a Race condition. This ends on an error trying to publish a too large route which is not allowed by Route53

Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@jparrill jparrill marked this pull request as ready for review October 6, 2022 13:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2022
@openshift-ci openshift-ci bot requested review from csrwng and sjenning October 6, 2022 13:38
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

@jparrill: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity e5f0f2c link false /test capi-provider-agent-sanity
ci/prow/kubevirt-e2e-kubevirt-azure-ovn e5f0f2c link false /test kubevirt-e2e-kubevirt-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented Oct 10, 2022

/approve
PTAL @sjenning

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@sjenning
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@openshift-merge-robot openshift-merge-robot merged commit ddf3c65 into openshift:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants