Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate image for route controller manager #1790

Merged

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Oct 6, 2022

What this PR does / why we need it:
The route controller manager was recently separated into its own image and is no longer a subcommand of openshift-controller-manager. This change switches to using the separate route-controller-manager image and adjusts the deployment for it accordingly.

Checklist

  • Subject and description added to both, commit and PR.

The route controller manager was recently separated into its own image
and is no longer a subcommand of openshift-controller-manager. This
change switches to using the separate route-controller-manager image and
adjusts the deployment for it accordingly.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@csrwng
Copy link
Contributor Author

csrwng commented Oct 6, 2022

@yuqi-zhang
Copy link
Contributor

/test e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

@csrwng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity 84b09a2 link false /test capi-provider-agent-sanity
ci/prow/kubevirt-e2e-kubevirt-azure-ovn 84b09a2 link false /test kubevirt-e2e-kubevirt-azure-ovn
ci/prow/e2e-ibmcloud-roks 84b09a2 link false /test e2e-ibmcloud-roks
ci/prow/kubevirt-e2e-kubevirt-gcp-ovn 84b09a2 link false /test kubevirt-e2e-kubevirt-gcp-ovn
ci/prow/e2e-ibmcloud-iks 84b09a2 link false /test e2e-ibmcloud-iks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jparrill
Copy link
Contributor

jparrill commented Oct 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit fa0ca3d into openshift:main Oct 7, 2022
@csrwng csrwng deleted the fix_route_controller_deployment branch July 14, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants