Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate awsendpoint deletion #1813

Merged
merged 1 commit into from Nov 16, 2022
Merged

Validate awsendpoint deletion #1813

merged 1 commit into from Nov 16, 2022

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Oct 18, 2022 •
edited

What this PR does / why we need it:
With current implementation the cpo private link controller will consider deletion successfull after making the request, however if the resource keeps existing somehow in AWS it would prevent the deletion of the awsendpointService resource by the HO AWSEndpointServiceReconciler with "failed to delete resource: Service has existing active VPC Endpoint connections!"

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Ref https://issues.redhat.com/browse/HOSTEDCP-597

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@enxebre
Copy link
Member Author

enxebre commented Oct 18, 2022

PTAL @sjenning

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
@sjenning
Copy link
Contributor

I have observed this in the past as well
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5f903f2 and 2 for PR HEAD e16931c in total

@enxebre
Copy link
Member Author

enxebre commented Oct 19, 2022

/test e2e-aws

1 similar comment
@enxebre
Copy link
Member Author

enxebre commented Oct 20, 2022

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Oct 20, 2022

Seems the awsendpointService not going away https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_hypershift/1813/pull-ci-openshift-hypershift-main-e2e-aws/1583003565050302464/artifacts/e2e-aws/run-e2e/artifacts/TestCreateCluster_DestroyCluster_1/namespaces/e2e-clusters-v5qb5-example-p4rcc/hypershift.openshift.io/awsendpointservices/private-router.yaml
?

@enxebre
Copy link
Member Author

enxebre commented Oct 26, 2022

/test e2e-aws

2 similar comments
@enxebre
Copy link
Member Author

enxebre commented Oct 27, 2022

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Nov 1, 2022

/test e2e-aws

@sjenning
Copy link
Contributor

sjenning commented Nov 2, 2022

/retest-required

@sjenning
Copy link
Contributor

sjenning commented Nov 4, 2022

/retest-required
after #1839

@enxebre
Copy link
Member Author

enxebre commented Nov 8, 2022

/test e2e-aws

3 similar comments
@enxebre
Copy link
Member Author

enxebre commented Nov 9, 2022

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Nov 10, 2022

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Nov 10, 2022

/test e2e-aws

@csrwng
Copy link
Contributor

csrwng commented Nov 11, 2022

/retest-required

@enxebre
Validate awsendpoint deletion
54a48b6 
With current implementation the cpo private link controller will consider deletion successfull after making the request, however if the resource keeps existing somehow in AWS it would prevent the deletion of the awsendpointService resource by the HO AWSEndpointServiceReconciler with "failed to delete resource: Service has existing active VPC Endpoint connections!"
https://issues.redhat.com/browse/HOSTEDCP-597
@enxebre enxebre force-pushed the validate-awsendpoint-deletion branch from e16931c to 54a48b6 Compare November 11, 2022 10:32
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2022
@netlify
Copy link

netlify bot commented Nov 11, 2022

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 54a48b6
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/636e24c5ed1dde0008eb12b5
😎 Deploy Preview https://deploy-preview-1813--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@enxebre
Copy link
Member Author

enxebre commented Nov 11, 2022

/test e2e-aws

3 similar comments
@enxebre
Copy link
Member Author

enxebre commented Nov 11, 2022

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Nov 13, 2022

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Nov 14, 2022

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Nov 15, 2022

/test e2e-aws

2 similar comments
@enxebre
Copy link
Member Author

enxebre commented Nov 15, 2022

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Nov 15, 2022

/test e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2022 •
edited

@enxebre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks e16931c link false /test e2e-ibmcloud-roks
ci/prow/e2e-ibmcloud-iks e16931c link false /test e2e-ibmcloud-iks
ci/prow/periodics-4.13-images e16931c link true /test periodics-4.13-images
ci/prow/kubevirt-e2e-kubevirt-azure-ovn 54a48b6 link false /test kubevirt-e2e-kubevirt-azure-ovn
ci/prow/capi-provider-agent-sanity 54a48b6 link false /test capi-provider-agent-sanity

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member Author

enxebre commented Nov 15, 2022

/test e2e-aws

@sjenning
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@openshift-merge-robot openshift-merge-robot merged commit e681040 into openshift:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enxebre @sjenning @openshift-ci-robot @csrwng @openshift-merge-robot