Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Agent provider docs #1814

Merged
merged 1 commit into from Oct 20, 2022
Merged

Updated Agent provider docs #1814

merged 1 commit into from Oct 20, 2022

Conversation

mvazquezc
Copy link
Member

Signed-off-by: Mario Vazquez mavazque@redhat.com

What this PR does / why we need it:

Updates the agent provider docs.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from csrwng and enxebre October 18, 2022 16:48
@netlify
Copy link

netlify bot commented Oct 18, 2022 •
edited

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 3211877
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/634fa616002af40009d1b79a
😎 Deploy Preview https://deploy-preview-1814--hypershift-docs.netlify.app/how-to/agent/create-agent-cluster
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jparrill
jparrill suggested changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks fir the PR :), there are some just minor changes to be fixed. Apart from that lgtm

docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
@mvazquezc mvazquezc force-pushed the update-agent-docs branch 2 times, most recently from 4bf911b to 6e38bd3 Compare October 18, 2022 18:36
@jparrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022
imain
imain reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@imain imain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! Just a few English nits :).

docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
docs/content/how-to/agent/create-agent-cluster.md Outdated Show resolved Hide resolved
@mvazquezc
Updated Agent provider docs
3211877 
Signed-off-by: Mario Vazquez <mavazque@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@jparrill
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@jparrill
Copy link
Contributor

ohh cannot approve yet xD, could you @enxebre or @sjenning? tyty

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

@mvazquezc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/kubevirt-e2e-kubevirt-azure-ovn 3211877 link false /test kubevirt-e2e-kubevirt-azure-ovn
ci/prow/capi-provider-agent-sanity 3211877 link false /test capi-provider-agent-sanity

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented Oct 20, 2022

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, jparrill, mvazquezc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022
@openshift-merge-robot openshift-merge-robot merged commit e12d064 into openshift:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imain imain imain left review comments

@jparrill jparrill jparrill requested changes

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@enxebre enxebre

@jparrill jparrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mvazquezc @jparrill @enxebre @imain @openshift-merge-robot