Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerVS: Use name param on DHCP server create and delete #1815

Closed
wants to merge 2 commits into from
Closed

PowerVS: Use name param on DHCP server create and delete #1815

wants to merge 2 commits into from

Conversation

dharaneeshvrd
Copy link
Member

@dharaneeshvrd dharaneeshvrd commented Oct 19, 2022 •
edited

What this PR does / why we need it:

Fixes https://issues.redhat.com/browse/MULTIARCH-2972

Previously one DHCP server was allowed per PowerVS instance, now n number of DHCP servers can be created. So, refactored useExistingDHCP() and its test case accordingly.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from csrwng and enxebre October 19, 2022 05:06
@netlify
Copy link

netlify bot commented Oct 19, 2022 •
edited

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 4f9b32f
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/63735edf3fd99f0008d65443
😎 Deploy Preview https://deploy-preview-1815--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mkumatag
mkumatag suggested changes Oct 20, 2022
View reviewed changes
cmd/infra/powervs/destroy.go Outdated
// In case of user provided cloud instance delete only DHCP server
err = destroyPowerVsDhcpServer(ctx, infra, cloudInstanceID, session, options.InfraID)
} else {
if options.CloudInstanceID == "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets have early return by

Suggested change
if options.CloudInstanceID == "" {
if options.CloudInstanceID != "" {
log(options.InfraID).Info("skipping the cloud instance because user supplied")
return nil
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

mkumatag
mkumatag suggested changes Oct 20, 2022
View reviewed changes
cmd/infra/powervs/destroy.go Outdated
// In case of user provided cloud instance delete only DHCP server
err = destroyPowerVsDhcpServer(ctx, infra, cloudInstanceID, session, options.InfraID)
log(options.InfraID).Info("Skipping cloud instance deletion because user supplied")
return nil
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this cab be outside if/else block because I just this one whole block of code nothing post that..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dharaneeshvrd dharaneeshvrd force-pushed the powervs-dhcp-name branch 2 times, most recently from abdd918 to 0a29196 Compare October 20, 2022 15:17
@dharaneeshvrd
Copy link
Member Author

Updated the PR description and code on multiple DHCP server's support. Ptal @mkumatag.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dharaneeshvrd
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval by writing /assign @enxebre in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dharaneeshvrd
Copy link
Member Author

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2022
@dharaneeshvrd
Copy link
Member Author

/retest-required

@dharaneeshvrd dharaneeshvrd force-pushed the powervs-dhcp-name branch 3 times, most recently from dff0fdf to bb19062 Compare November 15, 2022 11:10
@dharaneeshvrd
Use name param on DHCP server create and delete
e4f5103 
Refactor DHCP server logic from one server per cloud instance to n number of DHCP servers
@dharaneeshvrd
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2023

@dharaneeshvrd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks 0a29196 link false /test e2e-ibmcloud-roks
ci/prow/e2e-ibmcloud-iks 0a29196 link false /test e2e-ibmcloud-iks
ci/prow/capi-provider-agent-sanity 324d6ed link false /test capi-provider-agent-sanity
ci/prow/kubevirt-e2e-kubevirt-azure-ovn 324d6ed link false /test kubevirt-e2e-kubevirt-azure-ovn
ci/prow/e2e-aws 324d6ed link true /test e2e-aws
ci/prow/verify 324d6ed link true /test verify
ci/prow/unit 324d6ed link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2023
@enxebre
Copy link
Member

enxebre commented May 4, 2023

Closing due to age, feel free to reopen if still relevant. Thanks!!
/close

@enxebre enxebre closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag requested changes

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@mkumatag mkumatag

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dharaneeshvrd @openshift-merge-robot @openshift-bot @enxebre @mkumatag