Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: HOSTEDCP-582: Add CEL validations to hostedcluster v1beta1 #1911

Closed
wants to merge 1 commit into from
Closed

WIP: HOSTEDCP-582: Add CEL validations to hostedcluster v1beta1 #1911

wants to merge 1 commit into from

Commits on Dec 14, 2022

  1. WIP: HOSTEDCP-582: Add CEL validations to hostedcluster v1beta1 

    This uses CEL validations available in kubernetes 1.25 and above,
requiring OpenShift 4.12 or greater.  I have tested with OpenShift 4.10
and while the validations do not work, they are also ignored so it should
be safe to have them in place for all versions.

Note that I am not setting maxLength here for the strings. I looked
through the source code and it seems for simple string comparisons we
should be OK here. I'd really rather not have to set this if we don't have
to. However if we run into issues we'll have to think about setting it.

Still a WIP as I need to do more testing.
    @imain
    imain committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    68c7ce4 View commit details
    Browse the repository at this point in the history