Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ho): Use v1alpha1 ownerRef for future CPO managed components #1959

Merged
merged 1 commit into from Jan 5, 2023

Conversation

hasueki
Copy link
Contributor

@hasueki hasueki commented Dec 15, 2022

What this PR does / why we need it:
Updates HO to continue using v1alpha1 ownerRefs for components (cluster-autoscaler, machine-approver, ignition-server) that will eventually move to CPO management. This will be the case for HCs < 4.12.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #1955

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@hasueki hasueki requested review from csrwng and removed request for sjenning December 16, 2022 16:55
@enxebre
Copy link
Member

enxebre commented Dec 20, 2022

/hold
to prevent ci from rerunning in this high prio PR

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2022
@enxebre
Copy link
Member

enxebre commented Dec 20, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2022
@hasueki
Copy link
Contributor Author

hasueki commented Dec 20, 2022

@csrwng Updated based on your feedback. Please re-review when you get a chance.

@csrwng
Copy link
Contributor

csrwng commented Dec 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2022
@csrwng
Copy link
Contributor

csrwng commented Jan 5, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, hasueki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023

@hasueki: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a22950a into openshift:main Jan 5, 2023
@hasueki hasueki deleted the fix-owner-ref branch January 5, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade path from 4.10 to 4.11 is broken with v1beta1 support
4 participants