Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "AUTH-323: remove rootCA from CA bundle for etcd certs" #1979

Closed
wants to merge 1 commit into from
Closed

Revert "AUTH-323: remove rootCA from CA bundle for etcd certs" #1979

wants to merge 1 commit into from

Conversation

ibihim
Copy link
Contributor

@ibihim ibihim commented Dec 21, 2022

Reverts #1948

What

First of 2 PRs that try to fix CI by reverting the changes to the etcd certificates.
We need to first add the rootCA to the CA bundle of etcd, before removing the etcd-signer signed etcd certificates.

Why

The etcd peers can't talk to each other in HA mode. The reason is that the IP gets verified in addition to the DNS names.

This is the current working assumption.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibihim
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval by writing /assign @enxebre in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2022

@ibihim: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 6acc1f2 link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ibihim ibihim closed this by deleting the head repository Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant