Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-4973: Reinstate hosted cluster configuration propagation #1980

Merged
merged 1 commit into from Dec 22, 2022

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Dec 21, 2022

What this PR does / why we need it:
The code that propagated the HostedCluster configuration spec to the HostedControlPlane resource was dropped in the v1beta1 PR. This PR reinstates the propagation of the configuration to the HostedControlPlane resource.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-4973

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

The code that propagated the HostedCluster configuration spec to the
HostedControlPlane resource was dropped in the v1beta1 PR.
This PR reinstates the propagation of the configuration to the
HostedControlPlane resource.
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 21, 2022
@openshift-ci-robot
Copy link

@csrwng: This pull request references Jira Issue OCPBUGS-4973, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.12" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
The code that propagated the HostedCluster configuration spec to the HostedControlPlane resource was dropped in the v1beta1 PR. This PR reinstates the propagation of the configuration to the HostedControlPlane resource.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-4973

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2022
@csrwng
Copy link
Contributor Author

csrwng commented Dec 21, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 21, 2022
@openshift-ci-robot
Copy link

@csrwng: This pull request references Jira Issue OCPBUGS-4973, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 21, 2022
@sjenning
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 56554d0 and 2 for PR HEAD a6ee9da in total

@csrwng
Copy link
Contributor Author

csrwng commented Dec 21, 2022

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2022

@csrwng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9426174 into openshift:main Dec 22, 2022
@openshift-ci-robot
Copy link

@csrwng: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4973 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
The code that propagated the HostedCluster configuration spec to the HostedControlPlane resource was dropped in the v1beta1 PR. This PR reinstates the propagation of the configuration to the HostedControlPlane resource.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-4973

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng
Copy link
Contributor Author

csrwng commented Dec 22, 2022

/cherry-pick release-4.12

@openshift-cherrypick-robot

@csrwng: new pull request created: #1981

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants