Makefile: Include full 'git diff' output #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because [1]: Makefile:54: *** untracked files detected: M api/v1beta1/hosted_controlplane.go M api/v1beta1/zz_generated.deepcopy.go M cmd/install/assets/hypershift-operator/hypershift.openshift.io_hostedclusters.yaml M cmd/install/assets/hypershift-operator/hypershift.openshift.io_hostedcontrolplanes.yaml M hack/app-sre/saas_template.yaml. Stop. isn't as easy for contributors to fix, vs. giving them a patch with recommended changes to make to their local checkout, to bring it in line with what CI is expecting. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_hypershift/1954/pull-ci-openshift-hypershift-main-verify/1603153782781251584#1:build-log.txt%3A290
|
/lgtm |
|
thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
isn't as easy for contributors to fix, vs. giving them a patch with recommended changes to make to their local checkout, to bring it in line with what CI is expecting.
And actually, even with this pull request, I had trouble figuring out the changes I wanted, so in #1954, I've been supplementing with f77a0c4's:
to give some base-64 that's easier to copy/paste out of the log without needing to worry about whitespace corruption and similar.