Use tags to filter resources on powervs infra destroy #2098
Conversation
|
/cc @mkumatag |
|
/retest-required |
cmd/infra/powervs/destroy.go
Outdated
| errL = append(errL, fmt.Errorf("error creating powervs session: %w", err)) | ||
| log(options.InfraID).Error(err, "error creating powervs session") |
There was a problem hiding this comment.
Why do we even continue if createPowerVSSession fails? may be we need to create a function for this so that we can safely return instead of continuing
There was a problem hiding this comment.
Refactored the code to use separate func for destroying resources in powervs and vpc. ptal!
cmd/infra/powervs/destroy.go
Outdated
| if err = destroyPowerVsCloudConnection(ctx, options, infra, powerVsCloudInstanceID, session); err != nil { | ||
| errL = append(errL, fmt.Errorf("error destroying powervs cloud connection: %w", err)) | ||
| log(options.InfraID).Error(err, "error destroying powervs cloud connection") | ||
| if session != nil { |
There was a problem hiding this comment.
if function is used, this check may not be required.
| } | ||
| } | ||
|
|
||
| v1, err := createVpcService(options.VPCRegion, options.InfraID) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
lets make function for handling each service cleanup as mention in the previous comment.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dharaneeshvrd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dharaneeshvrd
force-pushed
the
powervs-filter-by-tag
branch
from
776dd2f
to
bee6950
Compare
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dharaneeshvrd
force-pushed
the
powervs-filter-by-tag
branch
from
bee6950
to
872e49d
Compare
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
@dharaneeshvrd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Fixes https://issues.redhat.com/browse/MULTIARCH-2957
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist