Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] feat(HCCO): Block DNS operator delete until Cluster Version updated #2242

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2223

/assign hasueki

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: hasueki.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #2223

/assign hasueki

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hasueki
Copy link
Contributor

hasueki commented Mar 3, 2023

/area control-plane-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

@hasueki: Can not set label area/control-plane-operator: Must be member in one of these teams: []

In response to this:

/area control-plane-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hasueki
Copy link
Contributor

hasueki commented Mar 4, 2023

/cc @csrwng

@openshift-ci openshift-ci bot requested a review from csrwng March 4, 2023 00:19
@bryan-cox
Copy link
Member

/area control-plane-operator

@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Mar 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2023

@bryan-cox: The label(s) area/ cannot be applied, because the repository doesn't have them.

In response to this:

/area control-plane-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng
Copy link
Contributor

csrwng commented Mar 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
@sjenning
Copy link
Contributor

sjenning commented Mar 6, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 9cc10e0 into openshift:release-4.12 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants