Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create external Routes for Private clusters #2257

Closed
wants to merge 1 commit into from
Closed

create external Routes for Private clusters #2257

wants to merge 1 commit into from

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Mar 6, 2023

Part of https://issues.redhat.com/browse/HOSTEDCP-801

We need to maintain the routes for the external KAS and OAuth names even when the cluster is Private so that traffic coming across the PrivateLink using those name are properly routed.

Strictly speaking, this isn't required for the KAS because it is the default service for the HCP router, but we should make it explicit.

@openshift-ci openshift-ci bot requested review from csrwng and enxebre March 6, 2023 18:32
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Mar 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Mar 6, 2023
@sjenning sjenning force-pushed the always-kas-route branch 2 times, most recently from d185753 to b1d931d Compare March 8, 2023 17:55
@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Mar 8, 2023
@csrwng
Copy link
Contributor

csrwng commented Mar 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5baf27a and 2 for PR HEAD eb11dfa in total

@sjenning
Copy link
Contributor Author

sjenning commented Mar 8, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2023
@sjenning
Copy link
Contributor Author

sjenning commented Mar 8, 2023

/hold cancel

@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2023

@sjenning: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks 82c426f link false /test e2e-ibmcloud-iks
ci/prow/e2e-aws 82c426f link true /test e2e-aws
ci/prow/e2e-ibmcloud-roks 82c426f link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

included in #2286
/close

@openshift-ci openshift-ci bot closed this Mar 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@sjenning: Closed this PR.

In response to this:

included in #2286
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjenning @csrwng @openshift-ci-robot @openshift-merge-robot