HOSTEDCP-807: Check KAS loadbalancer health #2264

muraee · 2023-03-08T10:21:04Z

What this PR does / why we need it:
This enhances HCAvailable condition to better represent day2 state

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-807

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

openshift-ci-robot · 2023-03-08T10:21:08Z

@muraee: This pull request references HOSTEDCP-807 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-807

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-10T16:47:12Z

@muraee: This pull request references HOSTEDCP-807 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-807

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-10T16:47:13Z

@muraee: This pull request references HOSTEDCP-807 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-807

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-10T16:47:26Z

@muraee: This pull request references HOSTEDCP-807 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
This enhances HCAvailable condition to better represent day2 state

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-807

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

csrwng

Some comments. Thx!

control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go

netlify · 2023-03-13T10:11:24Z

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	`254a049`
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/641980bf72a7db00081b9632
😎 Deploy Preview	https://deploy-preview-2264--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

muraee · 2023-03-14T09:26:12Z

/retest-required

muraee · 2023-03-16T13:50:58Z

/retest-required

muraee · 2023-03-16T16:02:59Z

/retest-required

csrwng · 2023-03-21T18:41:16Z

/approve

csrwng · 2023-03-21T18:41:25Z

/retest-required

openshift-ci · 2023-03-21T18:45:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

muraee · 2023-03-24T09:06:13Z

/retest-required

enxebre · 2023-03-27T08:54:32Z

test/e2e/util/oauth.go

@@ -106,7 +106,7 @@ func WaitForOAuthToken(t *testing.T, ctx context.Context, oauthRoute *routev1.Ro
 	}

 	var access_token string
-	err = wait.PollImmediateWithContext(ctx, time.Second, time.Minute, func(ctx context.Context) (done bool, err error) {
+	err = wait.PollImmediateWithContext(ctx, time.Second, time.Minute*2, func(ctx context.Context) (done bool, err error) {


why this change?

oauth idp test was failing, Cesar suggested that the configuration are not propagated in time before this test times out.

control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go

enxebre · 2023-03-27T08:56:58Z

/lgtm

openshift-ci-robot · 2023-03-27T09:29:29Z

/retest-required

Remaining retests: 0 against base HEAD a0377ae and 2 for PR HEAD d331c28 in total

muraee · 2023-03-29T07:29:33Z

/retest-required

muraee · 2023-03-31T09:05:46Z

/retest-required

control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go

This enhances HCAvailable condition to better represent day2 state

bryan-cox · 2023-04-03T12:43:15Z

/lgtm

openshift-ci · 2023-04-03T15:07:02Z

@muraee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ibmcloud-roks	`db22a8b`	link	false	`/test e2e-ibmcloud-roks`
ci/prow/e2e-ibmcloud-iks	`db22a8b`	link	false	`/test e2e-ibmcloud-iks`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

muraee · 2023-04-03T15:32:06Z

/cherry-pick release-4.13

openshift-cherrypick-robot · 2023-04-03T15:32:54Z

@muraee: new pull request created: #2369

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 8, 2023

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area labels Mar 8, 2023

openshift-ci bot requested review from csrwng and sjenning March 8, 2023 10:21

muraee force-pushed the kas-external-ednpoint-health-check branch from 02efd3b to 88d381e Compare March 10, 2023 16:46

muraee changed the title ~~WIP: HOSTEDCP-807: Check KAS loadbalancer health~~ HOSTEDCP-807: Check KAS loadbalancer health Mar 10, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2023

csrwng reviewed Mar 10, 2023

View reviewed changes

muraee force-pushed the kas-external-ednpoint-health-check branch from 88d381e to 21f128f Compare March 13, 2023 10:10

muraee force-pushed the kas-external-ednpoint-health-check branch from 21f128f to 1a917d4 Compare March 14, 2023 13:10

muraee force-pushed the kas-external-ednpoint-health-check branch from 1a917d4 to 254a049 Compare March 21, 2023 10:02

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023

enxebre reviewed Mar 27, 2023

View reviewed changes

control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go Show resolved Hide resolved

openshift-ci bot assigned enxebre Mar 27, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2023

muraee force-pushed the kas-external-ednpoint-health-check branch from d331c28 to 5ee80dc Compare March 28, 2023 15:32

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023

muraee force-pushed the kas-external-ednpoint-health-check branch from 5ee80dc to f6927ce Compare March 28, 2023 15:35

bryan-cox reviewed Apr 3, 2023

View reviewed changes

control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go Outdated Show resolved Hide resolved

Check KAS loadbalancer health

db22a8b

This enhances HCAvailable condition to better represent day2 state

muraee force-pushed the kas-external-ednpoint-health-check branch from f6927ce to db22a8b Compare April 3, 2023 12:42

openshift-ci bot assigned bryan-cox Apr 3, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023

openshift-merge-robot merged commit 7ab8c17 into openshift:main Apr 3, 2023
12 of 14 checks passed

openshift-cherrypick-robot mentioned this pull request Apr 3, 2023

[release-4.13] HOSTEDCP-807: Check KAS loadbalancer health #2369

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HOSTEDCP-807: Check KAS loadbalancer health #2264

HOSTEDCP-807: Check KAS loadbalancer health #2264

muraee commented Mar 8, 2023 •

edited

openshift-ci-robot commented Mar 8, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Mar 10, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Mar 10, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Mar 10, 2023 •

edited by openshift-ci bot

csrwng left a comment

netlify bot commented Mar 13, 2023 •

edited

muraee commented Mar 14, 2023

muraee commented Mar 16, 2023

muraee commented Mar 16, 2023

csrwng commented Mar 21, 2023

csrwng commented Mar 21, 2023

openshift-ci bot commented Mar 21, 2023

muraee commented Mar 24, 2023

enxebre Mar 27, 2023

muraee Mar 28, 2023

enxebre commented Mar 27, 2023

openshift-ci-robot commented Mar 27, 2023

muraee commented Mar 29, 2023

muraee commented Mar 31, 2023

bryan-cox commented Apr 3, 2023

openshift-ci bot commented Apr 3, 2023

muraee commented Apr 3, 2023

openshift-cherrypick-robot commented Apr 3, 2023

HOSTEDCP-807: Check KAS loadbalancer health #2264

HOSTEDCP-807: Check KAS loadbalancer health #2264

Conversation

muraee commented Mar 8, 2023 • edited

openshift-ci-robot commented Mar 8, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Mar 10, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Mar 10, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Mar 10, 2023 • edited by openshift-ci bot

csrwng left a comment

Choose a reason for hiding this comment

netlify bot commented Mar 13, 2023 • edited

✅ Deploy Preview for hypershift-docs ready!

muraee commented Mar 14, 2023

muraee commented Mar 16, 2023

muraee commented Mar 16, 2023

csrwng commented Mar 21, 2023

csrwng commented Mar 21, 2023

openshift-ci bot commented Mar 21, 2023

muraee commented Mar 24, 2023

enxebre Mar 27, 2023

Choose a reason for hiding this comment

muraee Mar 28, 2023

Choose a reason for hiding this comment

enxebre commented Mar 27, 2023

openshift-ci-robot commented Mar 27, 2023

muraee commented Mar 29, 2023

muraee commented Mar 31, 2023

bryan-cox commented Apr 3, 2023

openshift-ci bot commented Apr 3, 2023

muraee commented Apr 3, 2023

openshift-cherrypick-robot commented Apr 3, 2023

muraee commented Mar 8, 2023 •

edited

openshift-ci-robot commented Mar 8, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Mar 10, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Mar 10, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Mar 10, 2023 •

edited by openshift-ci bot

netlify bot commented Mar 13, 2023 •

edited