Leader election config update. #2282

cappetersson · 2023-03-15T19:40:21Z

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #1391

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

netlify · 2023-03-15T19:40:58Z

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	`335c3e4`
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/6489cacb069ef00008d40d55
😎 Deploy Preview	https://deploy-preview-2282--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cappetersson · 2023-03-31T18:09:29Z

/retest

hasueki · 2023-04-20T13:47:23Z

/lgtm

openshift-ci · 2023-04-20T13:47:57Z

@hasueki: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hasueki · 2023-04-20T21:12:05Z

/retest

hasueki · 2023-04-21T15:50:32Z

/retest

hasueki · 2023-04-26T22:36:21Z

/retest

a-dsouza · 2023-05-12T13:53:10Z

/retest

control-plane-operator/controllers/hostedcontrolplane/kcm/deployment.go

muraee · 2023-05-26T15:23:59Z

/lgtm

cappetersson · 2023-05-26T16:25:40Z

@muraee
I noticed that the ci/prow/e2e-aws-test is failing on other open PRs. Would this indicate that the error is not specific to my changes? Just checking to see if there are additional things I need to do to get this PR merged.

muraee · 2023-05-30T09:46:08Z

@cappetersson yeah, I think there was another problem last week.
/retest-required

cappetersson · 2023-05-30T14:32:35Z

@muraee
Is there anywhere I can check the status of the CI? Just to know if all tests should pass if my additions are correct. Please correct me if I'm wrong but the failing tests, both seems to be prometheus related, are not caused by my changes so therefor all I can do is wait until the CI is fixed and re-run the tests.

muraee · 2023-05-30T15:06:34Z

@cappetersson we don't have a direct way to check the status of our CI, we have a blocking job on CI stream so you could check the latest release for an indication (e.g. e2e-hypershift is failing here https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.ci/release/4.14.0-0.ci-2023-05-29-185629).

Actually we have a problem with our CI currently :)

cappetersson · 2023-05-30T20:51:29Z

Oh that is super helpful, thanks for showing me that @muraee! I will keep my eyes on the release page and then re-run the tests when I can see that those problems have been solved:+1:

cappetersson · 2023-06-02T13:15:58Z

/retest

cappetersson · 2023-06-02T16:19:36Z

@muraee
Do we need the two failing tests to pass before this PR can be merged?
Thanks

muraee · 2023-06-05T08:11:54Z

@cappetersson we need ci/prow/e2e-aws which is our main e2e test

cappetersson · 2023-06-05T13:35:11Z

/retest

cappetersson · 2023-06-15T13:05:48Z

/retest

muraee · 2023-06-15T13:14:04Z

@cappetersson kube-controller-manager logs show this:

Error: unknown flag: --leader-elect-renew-deadline-duration

The flag should be only --leader-elect-renew-deadline

cappetersson · 2023-06-15T13:43:31Z

Ah yes there it is. How were you able to know to look in that specific folder for the logs? Is that just something you know or would I be able to tell based on the information given by the failing tests.

muraee · 2023-06-15T13:49:10Z

well if all tests are failing without a clear reason, the first thing I do is to look at the HostedCluster/HostedControlPlane conditions which in this case shows:

  - lastTransitionTime: "2023-06-14T19:08:05Z"
    message: kube-controller-manager deployment has 1 unavailable replicas
    observedGeneration: 1
    reason: UnavailableReplicas
    status: "True"
    type: Degraded

so the next step naturally is to check the logs of the failing component.

cappetersson · 2023-06-20T14:25:24Z

/retest

cappetersson · 2023-06-21T20:50:39Z

/retest

cappetersson · 2023-06-22T16:09:59Z

@muraee

Finally was able to get all tests to pass. Thanks for all the help on this.

muraee · 2023-06-23T09:06:14Z

/lgtm

cappetersson · 2023-06-30T16:03:16Z

/retest

cappetersson · 2023-06-30T16:04:23Z

@muraee
Any idea on when I will be able to get some reviews on this?
Thanks

csrwng · 2023-07-03T14:00:12Z

/approve

openshift-ci · 2023-07-03T14:00:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cappetersson, csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-07-03T16:14:43Z

/retest-required

Remaining retests: 0 against base HEAD 56be8ca and 2 for PR HEAD 4586a24 in total

openshift-ci-robot · 2023-07-03T21:14:32Z

/retest-required

Remaining retests: 0 against base HEAD e2ca008 and 1 for PR HEAD 4586a24 in total

openshift-ci · 2023-07-03T23:00:53Z

@cappetersson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cappetersson · 2023-07-11T19:04:03Z

/cherry-pick release-4.12

openshift-cherrypick-robot · 2023-07-11T19:04:46Z

@cappetersson: new pull request created: #2800

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cappetersson · 2023-07-11T19:08:31Z

/cherry-pick release-4.13

cappetersson · 2023-07-11T19:08:41Z

/cherry-pick release-4.14

cappetersson · 2023-07-11T19:08:45Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2023-07-11T19:09:16Z

@cappetersson: new pull request created: #2801

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-07-11T19:09:27Z

@cappetersson: new pull request could not be created: failed to create pull request against openshift/hypershift#release-4.14 from head openshift-cherrypick-robot:cherry-pick-2282-to-release-4.14: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.14 and openshift-cherrypick-robot:cherry-pick-2282-to-release-4.14"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-07-11T19:09:32Z

@cappetersson: new pull request could not be created: failed to create pull request against openshift/hypershift#release-4.15 from head openshift-cherrypick-robot:cherry-pick-2282-to-release-4.15: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.15 and openshift-cherrypick-robot:cherry-pick-2282-to-release-4.15"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/needs-area label Mar 15, 2023

openshift-ci bot requested review from csrwng and enxebre March 15, 2023 19:41

openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Mar 15, 2023

cappetersson force-pushed the kcm-main branch from e768e2d to c00d3bb Compare March 16, 2023 15:10

cappetersson force-pushed the kcm-main branch from c00d3bb to 625266e Compare March 23, 2023 16:40

muraee reviewed May 15, 2023

View reviewed changes

control-plane-operator/controllers/hostedcontrolplane/kcm/deployment.go Outdated Show resolved Hide resolved

cappetersson requested a review from muraee May 26, 2023 13:21

openshift-ci bot assigned muraee May 26, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023

cappetersson force-pushed the kcm-main branch from ee37b38 to cd1d017 Compare June 5, 2023 15:51

Leader election config update.

4586a24

cappetersson force-pushed the kcm-main branch from 41e3755 to 4586a24 Compare June 15, 2023 13:46

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023

openshift-merge-robot merged commit 43e396a into openshift:main Jul 3, 2023
12 checks passed

openshift-cherrypick-robot mentioned this pull request Jul 11, 2023

[release-4.12] Leader election config update. #2800

Merged

openshift-cherrypick-robot mentioned this pull request Jul 11, 2023

[release-4.13] Leader election config update. #2801

Merged

Leader election config update. #2282

Leader election config update. #2282

Conversation

cappetersson commented Mar 15, 2023 • edited

netlify bot commented Mar 15, 2023 • edited

✅ Deploy Preview for hypershift-docs ready!

cappetersson commented Mar 31, 2023

hasueki commented Apr 20, 2023

openshift-ci bot commented Apr 20, 2023

hasueki commented Apr 20, 2023

hasueki commented Apr 21, 2023

hasueki commented Apr 26, 2023

a-dsouza commented May 12, 2023

muraee commented May 26, 2023

cappetersson commented May 26, 2023

muraee commented May 30, 2023

cappetersson commented May 30, 2023

muraee commented May 30, 2023 • edited

cappetersson commented May 30, 2023

cappetersson commented Jun 2, 2023

cappetersson commented Jun 2, 2023

muraee commented Jun 5, 2023

cappetersson commented Jun 5, 2023

cappetersson commented Jun 15, 2023

muraee commented Jun 15, 2023 • edited

cappetersson commented Jun 15, 2023

muraee commented Jun 15, 2023 • edited

cappetersson commented Jun 20, 2023

cappetersson commented Jun 21, 2023

cappetersson commented Jun 22, 2023

muraee commented Jun 23, 2023

cappetersson commented Jun 30, 2023

cappetersson commented Jun 30, 2023

csrwng commented Jul 3, 2023

openshift-ci bot commented Jul 3, 2023

openshift-ci-robot commented Jul 3, 2023

openshift-ci-robot commented Jul 3, 2023

openshift-ci bot commented Jul 3, 2023

cappetersson commented Jul 11, 2023

openshift-cherrypick-robot commented Jul 11, 2023

cappetersson commented Jul 11, 2023

cappetersson commented Jul 11, 2023

cappetersson commented Jul 11, 2023

openshift-cherrypick-robot commented Jul 11, 2023

openshift-cherrypick-robot commented Jul 11, 2023

openshift-cherrypick-robot commented Jul 11, 2023

cappetersson commented Mar 15, 2023 •

edited

netlify bot commented Mar 15, 2023 •

edited

muraee commented May 30, 2023 •

edited

muraee commented Jun 15, 2023 •

edited

muraee commented Jun 15, 2023 •

edited