Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-11607: properly reconcile with user specified changes for in proxy configuration #2395

Merged
merged 1 commit into from Apr 25, 2023
Merged

[release-4.12] OCPBUGS-11607: properly reconcile with user specified changes for in proxy configuration #2395

merged 1 commit into from Apr 25, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2382

/assign relyt0925

@relyt0925
properly reconcile with user specified changes for in proxy configura…
0dc4cf2 
…tion

Users are able to and directed to configure the cluster-wide proxy directly in the guest cluster when needing to setup local proxying in the guest cluster network: https://docs.openshift.com/container-platform/4.10/networking/enable-cluster-wide-proxy.html. Currently: even when the proxy configuration in the hosted cluster is nil: we are squashing all these changes and revoking what they are doing locally. This makes it impossible for them to configure the proxy within their network (they should not need to have to proxy these configurations to the hostedcluster resource each time and get it to propogate as that can be controlled by a separate entity like a managed cloud provider). This allows the user to create those changes and have them persist
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 10, 2023
Merged
4 tasks
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-11442 has been cloned as Jira Issue OCPBUGS-11607. Will retitle bug to link to clone.
/retitle [release-4.12] OCPBUGS-11607: properly reconcile with user specified changes for in proxy configuration

In response to this:

This is an automated cherry-pick of #2382

/assign relyt0925

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-11442: properly reconcile with user specified changes for in proxy configuration [release-4.12] OCPBUGS-11607: properly reconcile with user specified changes for in proxy configuration Apr 10, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 10, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-11607, which is invalid:

  • expected dependent Jira Issue OCPBUGS-11442 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-11442 to target a version in 4.13.0, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2382

/assign relyt0925

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-11607: properly reconcile with user specified changes for in proxy configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from csrwng and sjenning April 10, 2023 19:49
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Apr 10, 2023
@relyt0925
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2023
@enxebre
Copy link
Member

enxebre commented Apr 11, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@yuqi-zhang
Copy link
Contributor

/area control-plane-operator

@bryan-cox
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-11607, which is invalid:

  • expected dependent Jira Issue OCPBUGS-11606 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@relyt0925
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@relyt0925: This pull request references Jira Issue OCPBUGS-11607, which is invalid:

  • expected dependent Jira Issue OCPBUGS-11606 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@relyt0925
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@relyt0925: This pull request references Jira Issue OCPBUGS-11607, which is invalid:

  • expected dependent Jira Issue OCPBUGS-11606 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bryan-cox
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 25, 2023
@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-11607, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-11606 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-11606 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0e5723b into openshift:release-4.12 Apr 25, 2023
10 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-11607: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11607 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2382

/assign relyt0925

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@relyt0925 relyt0925

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @relyt0925 @enxebre @yuqi-zhang @bryan-cox @openshift-merge-robot