OCPBUGS-11939: Initialize RegistryOverrides w/ mgmt cluster ICSP #2437

bryan-cox · 2023-04-17T21:10:49Z

What this PR does / why we need it:
Includes any registry mirrors from ImageContentSourcePolicy (ICSP) and ImageDigestMirrorSet (IDMS) policies from the management cluster. Registry mirrors from these policies provide the cluster with alternatives to the default Operator Hub and image registries in disconnected environments.

Injects the trusted CA bundle from the openshift-config-managed pod into the HyperShift Operator pod. These additional CAs are needed in disconnected environments utilizing an OpenShift management cluster.

Which issue(s) this PR fixes:
Fixes OCPBUGS-11939

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.

openshift-ci-robot · 2023-04-17T21:10:52Z

@bryan-cox: This pull request references ACM-4093 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Initialize RegistryOverrides with the management cluster's ICSP if no value was passed in for the RegistryOverrides flag.

Which issue(s) this PR fixes:
Fixes ACM-4093

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-17T21:10:53Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

netlify · 2023-04-17T21:11:26Z

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	`58c2dd5`
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/6475defe05bfa2000890db27
😎 Deploy Preview	https://deploy-preview-2437--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

openshift-ci-robot · 2023-04-18T15:56:28Z

@bryan-cox: This pull request references ACM-4093 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Initialize RegistryOverrides with the management cluster's ICSP if no value was passed in for the RegistryOverrides flag.

Which issue(s) this PR fixes:
Fixes OCPBUGS-11939

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bryan-cox · 2023-04-18T15:57:04Z

/retitle OCPBUGS-11939: Initialize RegistryOverrides w/ mgmt cluster ICSP

openshift-ci-robot · 2023-04-18T15:57:16Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-11939, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
Initialize RegistryOverrides with the management cluster's ICSP if no value was passed in for the RegistryOverrides flag.

Which issue(s) this PR fixes:
Fixes OCPBUGS-11939

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bryan-cox · 2023-04-18T15:58:51Z

/jira refresh

openshift-ci-robot · 2023-04-18T15:59:00Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-11939, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (lshilin@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bryan-cox · 2023-04-18T18:26:45Z

/area control-plane-operator

bryan-cox · 2023-04-19T18:09:21Z

/test e2e-aws

bryan-cox · 2023-04-20T11:03:33Z

/test e2e-aws

bryan-cox · 2023-04-21T16:08:31Z

/test e2e-aws

bryan-cox · 2023-04-24T13:34:20Z

/test e2e-aws

https://issues.redhat.com/browse/HOSTEDCP-1000 Adds the CA certificates for mirror registries specified by the user to the ocm-trusted-ca-bundle ConfigMap created in openshift#2437 so that these certificates may be used to pull images from these mirror registries.

https://issues.redhat.com/browse/HOSTEDCP-1000 Adds the CA certificates for mirror registries specified by the user to the ocm-trusted-ca-bundle injected in openshift#2437 so that these certificates may be used to pull images from these mirror registries.

* HOSTEDCP-1000: Add image to management cluster capabilities https://issues.redhat.com/browse/HOSTEDCP-1000 image.config.openshift.io will need to be checked for the CAs for the image registries a user specifies. * HOSTEDCP-1000: Add user CA(s) to ocm-trusted-ca-bundle ConfigMap https://issues.redhat.com/browse/HOSTEDCP-1000 Adds the CA certificates for mirror registries specified by the user to the ocm-trusted-ca-bundle injected in #2437 so that these certificates may be used to pull images from these mirror registries. * HOSTEDCP-1000: Create Init container for hypershift operator https://issues.redhat.com/browse/HOSTEDCP-1000 Adds an init container to the hypershift operator to initialize the operator's environment. The init container includes changes for adding the user's CA bundle to the ocm-trusted-ca-bundle.

openshift-merge-robot · 2023-09-30T04:54:44Z

Fix included in accepted release 4.15.0-0.nightly-2023-09-30-003019

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2023

openshift-ci bot added do-not-merge/needs-area area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Apr 17, 2023

bryan-cox force-pushed the ACM-4093 branch from cd31218 to d99f0c6 Compare April 17, 2023 21:12

openshift-ci bot changed the title ~~ACM-4093: Initialize RegistryOverrides w/ mgmt cluster ICSP~~ OCPBUGS-11939: Initialize RegistryOverrides w/ mgmt cluster ICSP Apr 18, 2023

openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 18, 2023

bryan-cox force-pushed the ACM-4093 branch from d99f0c6 to 99354ea Compare April 18, 2023 18:25

openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Apr 18, 2023

bryan-cox force-pushed the ACM-4093 branch from 99354ea to 4cb3665 Compare April 20, 2023 11:03

bryan-cox force-pushed the ACM-4093 branch from 4cb3665 to b5c37d2 Compare April 21, 2023 14:30

bryan-cox force-pushed the ACM-4093 branch from b5c37d2 to bd09193 Compare April 24, 2023 20:34

CrystalChun mentioned this pull request Jun 21, 2023

HOSTEDCP-1000: Add user CA(s) to ocm-trusted-ca-bundle ConfigMap #2713

Merged

4 tasks

openshift-ci-robot mentioned this pull request Jul 13, 2023

OCPBUGS-11939: Fix additional issues with OCPBUGS-11939 #2804

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-11939: Initialize RegistryOverrides w/ mgmt cluster ICSP #2437

OCPBUGS-11939: Initialize RegistryOverrides w/ mgmt cluster ICSP #2437

bryan-cox commented Apr 17, 2023 •

edited

openshift-ci-robot commented Apr 17, 2023 •

edited by openshift-ci bot

openshift-ci bot commented Apr 17, 2023

netlify bot commented Apr 17, 2023 •

edited

openshift-ci-robot commented Apr 18, 2023 •

edited by openshift-ci bot

bryan-cox commented Apr 18, 2023

openshift-ci-robot commented Apr 18, 2023

bryan-cox commented Apr 18, 2023

openshift-ci-robot commented Apr 18, 2023

bryan-cox commented Apr 18, 2023

bryan-cox commented Apr 19, 2023

bryan-cox commented Apr 20, 2023

bryan-cox commented Apr 21, 2023

bryan-cox commented Apr 24, 2023

openshift-merge-robot commented Sep 30, 2023

OCPBUGS-11939: Initialize RegistryOverrides w/ mgmt cluster ICSP #2437

OCPBUGS-11939: Initialize RegistryOverrides w/ mgmt cluster ICSP #2437

Conversation

bryan-cox commented Apr 17, 2023 • edited

openshift-ci-robot commented Apr 17, 2023 • edited by openshift-ci bot

openshift-ci bot commented Apr 17, 2023

netlify bot commented Apr 17, 2023 • edited

✅ Deploy Preview for hypershift-docs ready!

openshift-ci-robot commented Apr 18, 2023 • edited by openshift-ci bot

bryan-cox commented Apr 18, 2023

openshift-ci-robot commented Apr 18, 2023

bryan-cox commented Apr 18, 2023

openshift-ci-robot commented Apr 18, 2023

bryan-cox commented Apr 18, 2023

bryan-cox commented Apr 19, 2023

bryan-cox commented Apr 20, 2023

bryan-cox commented Apr 21, 2023

bryan-cox commented Apr 24, 2023

openshift-merge-robot commented Sep 30, 2023

bryan-cox commented Apr 17, 2023 •

edited

openshift-ci-robot commented Apr 17, 2023 •

edited by openshift-ci bot

netlify bot commented Apr 17, 2023 •

edited

openshift-ci-robot commented Apr 18, 2023 •

edited by openshift-ci bot