New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACM-5116: Increase KubeVirt default Mem and Root Volume Sizes #2471
ACM-5116: Increase KubeVirt default Mem and Root Volume Sizes #2471
Conversation
This also adds option to set kubevirt core count in e2e tests, but does not change core number defaults Signed-off-by: David Vossel <davidvossel@gmail.com>
273996d
to
04fa847
Compare
Is there a related Jira ticket for this PR? |
yes. it is related to https://issues.redhat.com/browse/ACM-5116 |
/test e2e-kubevirt-aws-ovn |
/retitle ACM-5116: Increase KubeVirt default Mem and Root Volume Sizes |
@davidvossel: This pull request references ACM-5116 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@davidvossel: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ci/prow/e2e-aws is failing due to a current issue with CI with the KAS pod: |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.14.0-202305011815.p0.ge7eb32f.assembly.stream for distgit hypershift. |
Increases Mem defaults to 8gi
Increases Root Volume defaults to 32 Gi
Adds option to e2e tests to configure cpu counts and root volume size.
This aligns closer with the requirements set here, https://docs.openshift.com/container-platform/4.12/post_installation_configuration/node-tasks.html#rhel-compute-requirements_post-install-node-tasks
We're erroring on the side of overshooting the minimal root volume size by default in order to provide a more usable default experience. In practice, we've seen that the container images can fill up the root volume quickly depending on the workloads installed.