Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-5116: Increase KubeVirt default Mem and Root Volume Sizes #2471

Merged

Conversation

davidvossel
Copy link
Contributor

Increases Mem defaults to 8gi
Increases Root Volume defaults to 32 Gi
Adds option to e2e tests to configure cpu counts and root volume size.

This aligns closer with the requirements set here, https://docs.openshift.com/container-platform/4.12/post_installation_configuration/node-tasks.html#rhel-compute-requirements_post-install-node-tasks

We're erroring on the side of overshooting the minimal root volume size by default in order to provide a more usable default experience. In practice, we've seen that the container images can fill up the root volume quickly depending on the workloads installed.

@openshift-ci openshift-ci bot requested review from csrwng and nirarg April 25, 2023 15:04
@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Apr 25, 2023
This also adds option to set kubevirt core count in e2e tests, but does
not change core number defaults

Signed-off-by: David Vossel <davidvossel@gmail.com>
@bryan-cox
Copy link
Member

Is there a related Jira ticket for this PR?

@davidvossel
Copy link
Contributor Author

Is there a related Jira ticket for this PR?

yes. it is related to https://issues.redhat.com/browse/ACM-5116

@davidvossel
Copy link
Contributor Author

/test e2e-kubevirt-aws-ovn

@bryan-cox
Copy link
Member

bryan-cox commented Apr 28, 2023

/retitle ACM-5116: Increase KubeVirt default Mem and Root Volume Sizes

@openshift-ci openshift-ci bot changed the title Increase KubeVirt default Mem and Root Volume Sizes ACM-5116: Increase KubeVirt default Mem and Root Volume Sizes Apr 28, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 28, 2023

@davidvossel: This pull request references ACM-5116 which is a valid jira issue.

In response to this:

Increases Mem defaults to 8gi
Increases Root Volume defaults to 32 Gi
Adds option to e2e tests to configure cpu counts and root volume size.

This aligns closer with the requirements set here, https://docs.openshift.com/container-platform/4.12/post_installation_configuration/node-tasks.html#rhel-compute-requirements_post-install-node-tasks

We're erroring on the side of overshooting the minimal root volume size by default in order to provide a more usable default experience. In practice, we've seen that the container images can fill up the root volume quickly depending on the workloads installed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 1, 2023

@davidvossel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks 04fa847 link false /test e2e-ibmcloud-roks
ci/prow/e2e-ibmcloud-iks 04fa847 link false /test e2e-ibmcloud-iks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 12e6a50 and 2 for PR HEAD 04fa847 in total

@bryan-cox
Copy link
Member

ci/prow/e2e-aws is failing due to a current issue with CI with the KAS pod: Back-off pulling image "[registry.ci.openshift.org/hypershift/aws-encryption-provider:latest](http://registry.ci.openshift.org/hypershift/aws-encryption-provider:latest)"

@openshift-merge-robot openshift-merge-robot merged commit e7eb32f into openshift:main May 1, 2023
12 of 14 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.14.0-202305011815.p0.ge7eb32f.assembly.stream for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants