Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 4.12] OCPBUGS-11555: OAuth OpenShift deployment requires ConfigMap mount #2512

Merged

Conversation

imain
Copy link
Contributor

@imain imain commented May 3, 2023

This fixes the issue by checking to see if the config map for the CA Bundle exists, and only applying the config/using the volume if it does.

Note that this fix is against 4.12 only. This is to fix a Z stream upgrade issue from 4.12.8 to 4.12.9 and is not needed in 4.13 or main.

Introduced by #2295

Fixes: OCPBUGS-11555

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 3, 2023
@openshift-ci-robot
Copy link

@imain: This pull request references Jira Issue OCPBUGS-11555, which is invalid:

  • expected Jira Issue OCPBUGS-11555 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This fixes the issue by checking to see if the config map for the CA Bundle exists, and only applying the config/using the volume if it does.

Fixes: OCPBUGS-11555

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

@imain: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release 4.12] OCPBUGS-11555: OAuth OpenShift deployment requires ConfigMap mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from enxebre and sjenning May 3, 2023 20:26
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels May 3, 2023
@imain
Copy link
Contributor Author

imain commented May 3, 2023

/jira refresh

@openshift-ci-robot
Copy link

@imain: This pull request references Jira Issue OCPBUGS-11555, which is invalid:

  • expected dependent Jira Issue OCPBUGS-13073 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead
  • expected dependent Jira Issue OCPBUGS-13073 to target a version in 4.13.0, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imain
Copy link
Contributor Author

imain commented May 3, 2023

/jira refresh

@openshift-ci-robot
Copy link

@imain: This pull request references Jira Issue OCPBUGS-11555, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imain
Copy link
Contributor Author

imain commented May 3, 2023

/jira refresh

@openshift-ci-robot
Copy link

@imain: This pull request references Jira Issue OCPBUGS-11555, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imain
Copy link
Contributor Author

imain commented May 3, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 3, 2023
@openshift-ci-robot
Copy link

@imain: This pull request references Jira Issue OCPBUGS-11555, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13073 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13073 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@imain: This pull request references Jira Issue OCPBUGS-11555, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13073 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13073 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

In response to this:

This fixes the issue by checking to see if the config map for the CA Bundle exists, and only applying the config/using the volume if it does.

Note that this fix is against 4.12 only. This is to fix a Z stream upgrade issue from 4.12.8 to 4.12.9 and is not needed in 4.13 or main.

Fixes: OCPBUGS-11555

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2023

@imain: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release 4.12] OCPBUGS-11555: OAuth OpenShift deployment requires ConfigMap mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imain
Copy link
Contributor Author

imain commented May 9, 2023

/retest

2 similar comments
@imain
Copy link
Contributor Author

imain commented May 11, 2023

/retest

@imain
Copy link
Contributor Author

imain commented May 18, 2023

/retest

@enxebre
Copy link
Member

enxebre commented May 22, 2023

/test e2e-aws

@imain imain force-pushed the release-4.12-OCPBUGS-11555 branch 3 times, most recently from b929ebb to d9e3de3 Compare May 26, 2023 21:51
This fixes the issue by checking to see if the config map for the CA
Bundle exists, and only applying the config/using the volume if it
does.
@imain imain force-pushed the release-4.12-OCPBUGS-11555 branch from d9e3de3 to eaf7ffe Compare May 27, 2023 03:51
@enxebre
Copy link
Member

enxebre commented May 29, 2023

@imain Can you please reference the PR where we introduce the breaking req?
/approve
ptal @csrwng

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, imain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2023
@openshift-ci-robot
Copy link

@imain: This pull request references Jira Issue OCPBUGS-11555, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13073 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13073 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

In response to this:

This fixes the issue by checking to see if the config map for the CA Bundle exists, and only applying the config/using the volume if it does.

Note that this fix is against 4.12 only. This is to fix a Z stream upgrade issue from 4.12.8 to 4.12.9 and is not needed in 4.13 or main.

Introduced by #2295

Fixes: OCPBUGS-11555

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imain
Copy link
Contributor Author

imain commented May 29, 2023

Introduced by #2295

I added this to the commit above.

@csrwng
Copy link
Contributor

csrwng commented Jun 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9c90638 and 2 for PR HEAD eaf7ffe in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

@imain: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 90d3307 into openshift:release-4.12 Jun 13, 2023
10 checks passed
@openshift-ci-robot
Copy link

@imain: Jira Issue OCPBUGS-11555: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11555 has been moved to the MODIFIED state.

In response to this:

This fixes the issue by checking to see if the config map for the CA Bundle exists, and only applying the config/using the volume if it does.

Note that this fix is against 4.12 only. This is to fix a Z stream upgrade issue from 4.12.8 to 4.12.9 and is not needed in 4.13 or main.

Introduced by #2295

Fixes: OCPBUGS-11555

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants