New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release 4.12] OCPBUGS-11555: OAuth OpenShift deployment requires ConfigMap mount #2512
[release 4.12] OCPBUGS-11555: OAuth OpenShift deployment requires ConfigMap mount #2512
Conversation
@imain: This pull request references Jira Issue OCPBUGS-11555, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@imain: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@imain: This pull request references Jira Issue OCPBUGS-11555, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@imain: This pull request references Jira Issue OCPBUGS-11555, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@imain: This pull request references Jira Issue OCPBUGS-11555, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@imain: This pull request references Jira Issue OCPBUGS-11555, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@imain: This pull request references Jira Issue OCPBUGS-11555, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@imain: No Bugzilla bug is referenced in the title of this pull request. Retaining the bugzilla/valid-bug label as it was manually added. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
2 similar comments
/retest |
/retest |
/test e2e-aws |
b929ebb
to
d9e3de3
Compare
This fixes the issue by checking to see if the config map for the CA Bundle exists, and only applying the config/using the volume if it does.
d9e3de3
to
eaf7ffe
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, imain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@imain: This pull request references Jira Issue OCPBUGS-11555, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Introduced by #2295 I added this to the commit above. |
/lgtm |
@imain: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
90d3307
into
openshift:release-4.12
@imain: Jira Issue OCPBUGS-11555: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-11555 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This fixes the issue by checking to see if the config map for the CA Bundle exists, and only applying the config/using the volume if it does.
Note that this fix is against 4.12 only. This is to fix a Z stream upgrade issue from 4.12.8 to 4.12.9 and is not needed in 4.13 or main.
Introduced by #2295
Fixes: OCPBUGS-11555
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist