Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove flags set by CI env var #2521

Merged
merged 1 commit into from May 19, 2023
Merged

remove flags set by CI env var #2521

merged 1 commit into from May 19, 2023

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented May 4, 2023

Follow on to openshift/release#39012

Remove magic flag setting when running in CI. Workflow in o/r now explicitly sets these flags.

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels May 4, 2023
@sjenning
Copy link
Contributor Author

sjenning commented May 5, 2023

/retest-required

@enxebre
Copy link
Member

enxebre commented May 5, 2023

/test e2e-aws

1 similar comment
@bryan-cox
Copy link
Member

/test e2e-aws

bryan-cox
bryan-cox approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bryan-cox
Copy link
Member

Do we need to remove these lines from the e2e's too?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sjenning
Copy link
Contributor Author

sjenning commented May 5, 2023

/retest-required

@sjenning
Copy link
Contributor Author

/override hypershift-azjx-on-pull-request

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

@sjenning: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • hypershift-azjx-on-pull-request

Only the following failed contexts/checkruns were expected:

  • Red Hat Trusted App Pipeline
  • ci/prow/e2e-aws
  • ci/prow/e2e-kubevirt-aws-ovn
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • netlify/hypershift-docs/deploy-preview
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override hypershift-azjx-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

/override "Red Hat Trusted App Pipeline / hypershift-azjx-on-pull-request"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

@sjenning: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Red Hat Trusted App Pipeline / hypershift-azjx-on-pull-request

Only the following failed contexts/checkruns were expected:

  • Red Hat Trusted App Pipeline
  • ci/prow/e2e-aws
  • ci/prow/e2e-kubevirt-aws-ovn
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • netlify/hypershift-docs/deploy-preview
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Red Hat Trusted App Pipeline / hypershift-azjx-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

/override "Red Hat Trusted App Pipeline"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

@sjenning: Overrode contexts on behalf of sjenning: Red Hat Trusted App Pipeline

In response to this:

/override "Red Hat Trusted App Pipeline"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

/close

@openshift-ci openshift-ci bot closed this May 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

@sjenning: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

/reopen

@openshift-ci openshift-ci bot reopened this May 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

@sjenning: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

@sjenning: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kubevirt-aws-ovn 2cd5df8 link false /test e2e-kubevirt-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 396dd31 into openshift:main May 19, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryan-cox bryan-cox bryan-cox approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjenning @enxebre @bryan-cox @openshift-merge-robot