Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-24818: Add fsGroup support to kubevirt-csi-driver #2563

Merged
merged 2 commits into from Jun 14, 2023
Merged

CNV-24818: Add fsGroup support to kubevirt-csi-driver #2563

merged 2 commits into from Jun 14, 2023

Conversation

awels
Copy link
Contributor

@awels awels commented May 15, 2023

What this PR does / why we need it:
Add FSGroup support to kubevirt-csi-driver deployment. Add CSI driver resource because it was missing in hypershift deployments.

Source of CSIDriver:
kubevirt/csi-driver#87

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels May 15, 2023
@awels
Copy link
Contributor Author

awels commented May 15, 2023

/cc @davidvossel

@openshift-ci openshift-ci bot requested a review from davidvossel May 15, 2023 19:15
@davidvossel
Copy link
Contributor

/test e2e-kubevirt-aws-ovn

davidvossel
davidvossel reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

lets see how the e2e tests do before merging this

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@awels
Copy link
Contributor Author

awels commented May 16, 2023

/test e2e-kubevirt-aws-ovn

4 similar comments
@awels
Copy link
Contributor Author

awels commented May 16, 2023

/test e2e-kubevirt-aws-ovn

@awels
Copy link
Contributor Author

awels commented May 16, 2023

/test e2e-kubevirt-aws-ovn

@awels
Copy link
Contributor Author

awels commented May 16, 2023

/test e2e-kubevirt-aws-ovn

@awels
Copy link
Contributor Author

awels commented May 16, 2023

/test e2e-kubevirt-aws-ovn

@bryan-cox
Copy link
Member

Does this have an associated Jira ticket? See 4) in https://hypershift-docs.netlify.app/contribute/#creating-a-pull-request

@awels
Copy link
Contributor Author

awels commented May 17, 2023

Does this have an associated Jira ticket? See 4) in https://hypershift-docs.netlify.app/contribute/#creating-a-pull-request

Yes https://issues.redhat.com/browse/CNV-24818

@awels awels changed the title Add fsGroup support to kubevirt-csi-driver CNV-24818 Add fsGroup support to kubevirt-csi-driver May 17, 2023
@bryan-cox
Copy link
Member

bryan-cox commented May 17, 2023 •
edited by openshift-ci bot

/retitle CNV-24818: Add fsGroup support to kubevirt-csi-driver

@openshift-ci openshift-ci bot changed the title CNV-24818 Add fsGroup support to kubevirt-csi-driver CNV-24818: Add fsGroup support to kubevirt-csi-driver May 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 17, 2023 •
edited by openshift-ci bot

@awels: This pull request references CNV-24818 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Add FSGroup support to kubevirt-csi-driver deployment. Add CSI driver resource because it was missing in hypershift deployments.

Source of CSIDriver:
kubevirt/csi-driver#87

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2023
@awels
Copy link
Contributor Author

awels commented May 17, 2023

/test e2e-kubevirt-aws-ovn

7 similar comments
@awels
Copy link
Contributor Author

awels commented May 18, 2023

/test e2e-kubevirt-aws-ovn

@davidvossel
Copy link
Contributor

/test e2e-kubevirt-aws-ovn

@awels
Copy link
Contributor Author

awels commented May 30, 2023

/test e2e-kubevirt-aws-ovn

@awels
Copy link
Contributor Author

awels commented May 30, 2023

/test e2e-kubevirt-aws-ovn

@awels
Copy link
Contributor Author

awels commented May 30, 2023

/test e2e-kubevirt-aws-ovn

@awels
Copy link
Contributor Author

awels commented Jun 2, 2023

/test e2e-kubevirt-aws-ovn

@awels
Copy link
Contributor Author

awels commented Jun 12, 2023

/test e2e-kubevirt-aws-ovn

davidvossel
davidvossel reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c37a87f and 2 for PR HEAD 05021ee in total

@awels
Add fsGroup support to kubevirt-csi-driver
15c1705 
Added CSI driver resource to support fsGroup from
kubevirt/csi-driver#87

Signed-off-by: Alexander Wels <awels@redhat.com>
@awels
Switched to setting csidriver using code instead of reading yaml file
1b56bf9 
Signed-off-by: Alexander Wels <awels@redhat.com>
@awels awels force-pushed the add_csi_driver_kubevirt_resource branch from 05021ee to 1b56bf9 Compare June 12, 2023 20:57
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@awels
Copy link
Contributor Author

awels commented Jun 12, 2023

/test e2e-kubevirt-aws-ovn

2 similar comments
@awels
Copy link
Contributor Author

awels commented Jun 13, 2023

/test e2e-kubevirt-aws-ovn

@awels
Copy link
Contributor Author

awels commented Jun 13, 2023

/test e2e-kubevirt-aws-ovn

davidvossel
davidvossel approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels, davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@awels
Copy link
Contributor Author

awels commented Jun 13, 2023

/test e2e-kubevirt-aws-ovn

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD af3de4f and 2 for PR HEAD 1b56bf9 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f8a14a8 and 1 for PR HEAD 1b56bf9 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2023

@awels: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 30f95e1 into openshift:main Jun 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel approved these changes

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@nirarg nirarg Awaiting requested review from nirarg

Assignees

@davidvossel davidvossel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@awels @davidvossel @bryan-cox @openshift-ci-robot @openshift-merge-robot