OCPBUGS-13113: Add ClusterUpgradeDuration metric #2566

muraee · 2023-05-16T14:00:55Z

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-13113

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

openshift-ci-robot · 2023-05-16T14:00:59Z

@muraee: This pull request references Jira Issue OCPBUGS-13113, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-13113

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

muraee · 2023-05-16T14:38:39Z

/jira refresh

openshift-ci-robot · 2023-05-16T14:38:47Z

@muraee: This pull request references Jira Issue OCPBUGS-13113, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2023-05-17T08:35:30Z

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	`b08c699`
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/646b4c72d69901000850ec01
😎 Deploy Preview	https://deploy-preview-2566--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bryan-cox

/lgtm

enxebre · 2023-05-18T08:58:37Z

hypershift-operator/controllers/hostedcluster/metrics.go

+		return
+	}
+
+	newVersion := hc.Status.Version.History[0]


cc @wking to validate the assumptions about ordering here are valid.

enxebre · 2023-05-18T08:59:16Z

hypershift-operator/controllers/hostedcluster/metrics.go

@@ -92,3 +99,27 @@ func clusterVersionRolloutTime(hc *hyperv1.HostedCluster) *float64 {
 	}
 	return pointer.Float64(completionTime.Sub(hc.CreationTimestamp.Time).Seconds())
 }
+
+func RecordClusterUpgradeDuration(hc *hyperv1.HostedCluster) {


So just to clarify this would record the whole history every time that is run? which I guess is fine.

enxebre · 2023-05-18T09:01:01Z

This is nice! Can you please also include a PR to whitelist the metric here https://gitlab.cee.redhat.com/service/osd-fleet-manager/-/merge_requests/490 and include a panel here https://github.com/openshift/hypershift/tree/main/contrib/metrics

openshift-ci · 2023-05-24T11:29:51Z

@muraee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-kubevirt-aws-ovn	`064dde6`	link	false	`/test e2e-kubevirt-aws-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

muraee · 2023-05-25T08:23:00Z

/retest-required

enxebre · 2023-05-30T12:29:04Z

/approve
can you please link counter part PR to while list metric?

openshift-ci · 2023-05-30T12:36:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

imain · 2023-05-30T14:15:45Z

/lgtm

openshift-ci-robot · 2023-05-30T18:34:40Z

@muraee: Jira Issue OCPBUGS-13113: All pull requests linked via external trackers have merged:

openshift/hypershift#2566

Jira Issue OCPBUGS-13113 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-13113

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

muraee · 2023-06-01T15:23:35Z

/cherry-pick release-4.13

openshift-cherrypick-robot · 2023-06-01T15:24:50Z

@muraee: new pull request created: #2637

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 16, 2023

openshift-ci bot added the do-not-merge/needs-area label May 16, 2023

openshift-ci bot requested review from isco-rodriguez and sjenning May 16, 2023 14:04

openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels May 16, 2023

muraee force-pushed the upgrade-duration-metric branch from a6edee0 to f61a1cf Compare May 17, 2023 08:34

muraee force-pushed the upgrade-duration-metric branch from f61a1cf to e5482ec Compare May 17, 2023 08:35

bryan-cox approved these changes May 17, 2023

View reviewed changes

openshift-ci bot assigned bryan-cox May 17, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023

enxebre reviewed May 18, 2023

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2023

muraee force-pushed the upgrade-duration-metric branch from e5482ec to b08c699 Compare May 22, 2023 11:05

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2023

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2023

Add ClusterUpgradeDuration metric

064dde6

muraee force-pushed the upgrade-duration-metric branch from b08c699 to 064dde6 Compare May 24, 2023 09:05

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023

openshift-ci bot assigned imain May 30, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023

openshift-merge-robot merged commit d5a31a7 into openshift:main May 30, 2023
11 of 12 checks passed

openshift-cherrypick-robot mentioned this pull request Jun 1, 2023

[release-4.13] OCPBUGS-14436: Add ClusterUpgradeDuration metric #2637

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-13113: Add ClusterUpgradeDuration metric #2566

OCPBUGS-13113: Add ClusterUpgradeDuration metric #2566

muraee commented May 16, 2023

openshift-ci-robot commented May 16, 2023

muraee commented May 16, 2023

openshift-ci-robot commented May 16, 2023

netlify bot commented May 17, 2023 •

edited

bryan-cox left a comment

enxebre May 18, 2023

enxebre May 18, 2023

muraee May 19, 2023

enxebre commented May 18, 2023

openshift-ci bot commented May 24, 2023 •

edited

muraee commented May 25, 2023

enxebre commented May 30, 2023

openshift-ci bot commented May 30, 2023

imain commented May 30, 2023

openshift-ci-robot commented May 30, 2023

muraee commented Jun 1, 2023

openshift-cherrypick-robot commented Jun 1, 2023

OCPBUGS-13113: Add ClusterUpgradeDuration metric #2566

OCPBUGS-13113: Add ClusterUpgradeDuration metric #2566

Conversation

muraee commented May 16, 2023

openshift-ci-robot commented May 16, 2023

muraee commented May 16, 2023

openshift-ci-robot commented May 16, 2023

netlify bot commented May 17, 2023 • edited

✅ Deploy Preview for hypershift-docs ready!

bryan-cox left a comment

Choose a reason for hiding this comment

enxebre May 18, 2023

Choose a reason for hiding this comment

enxebre May 18, 2023

Choose a reason for hiding this comment

muraee May 19, 2023

Choose a reason for hiding this comment

enxebre commented May 18, 2023

openshift-ci bot commented May 24, 2023 • edited

muraee commented May 25, 2023

enxebre commented May 30, 2023

openshift-ci bot commented May 30, 2023

imain commented May 30, 2023

openshift-ci-robot commented May 30, 2023

muraee commented Jun 1, 2023

openshift-cherrypick-robot commented Jun 1, 2023

netlify bot commented May 17, 2023 •

edited

openshift-ci bot commented May 24, 2023 •

edited