Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Creating Arm NodePools Through the API' Section #2587

Merged

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
Adds 'Creating Arm NodePools Through the API' section to clarify how to create Arm NodePools through the API directly.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@netlify
Copy link

netlify bot commented May 23, 2023

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 9f54b27
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/646dfdb3a99d3c00086778e9
😎 Deploy Preview https://deploy-preview-2587--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bryan-cox
Copy link
Member Author

/area documentation

@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation and removed do-not-merge/needs-area labels May 23, 2023
@openshift-ci openshift-ci bot requested review from csrwng and enxebre May 23, 2023 12:48
Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
Adds 'Creating Arm NodePools Through the API' section to clarify how to
create Arm NodePools through the API directly.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kubevirt-aws-ovn 9f54b27 link false /test e2e-kubevirt-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lahinson
Copy link

@bryan-cox Would it make sense for me to add this info to the product docs for the upcoming ACM 2.8 release? https://github.com/stolostron/rhacm-docs/blob/2.8_stage/clusters/hosted_control_planes/managing_hosted_aws.adoc#hosted-cluster-arm-aws

@bryan-cox
Copy link
Member Author

@bryan-cox Would it make sense for me to add this info to the product docs for the upcoming ACM 2.8 release? https://github.com/stolostron/rhacm-docs/blob/2.8_stage/clusters/hosted_control_planes/managing_hosted_aws.adoc#hosted-cluster-arm-aws

@lahinson - Maybe? The Arm NodePool work is just for 4.14 and isn't being backported to earlier versions.

@lahinson
Copy link

@lahinson - Maybe? The Arm NodePool work is just for 4.14 and isn't being backported to earlier versions.

@bryan-cox Ah, okay. It would make more sense to add to the ACM 2.9 docs, then, as that release aligns with OCP 4.14. Thanks for confirming!

@csrwng
Copy link
Contributor

csrwng commented May 30, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@bryan-cox bryan-cox requested a review from jparrill May 30, 2023 15:59
@jparrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit a51caba into openshift:main May 31, 2023
8 of 9 checks passed
@bryan-cox bryan-cox deleted the UpdateArmNodePoolDoc branch June 27, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants