Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dump for Kubevirt #2589

Merged
merged 1 commit into from May 25, 2023
Merged

Fix dump for Kubevirt #2589

merged 1 commit into from May 25, 2023

Conversation

nunnatsa
Copy link
Contributor

  1. fixed wrong namespace
  2. only request kubevirt resources if kubevirt is in use, to avoid error of resource type unknown.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels May 23, 2023
davidvossel
davidvossel reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@nunnatsa
Copy link
Contributor Author

/hold

want to add VMI and VM resources.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@nunnatsa
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@nunnatsa
Copy link
Contributor Author

/test e2e-aws

@nunnatsa nunnatsa changed the title Fix bump for Kubevirt Fix dump for Kubevirt May 24, 2023
@davidvossel
Copy link
Contributor

/retest

@nunnatsa
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@nunnatsa
Fix bump for Kubevirt
5e33478 
1. fixed wrong namespace
2. only request kubevirt resources if kubevirt is in use, to avoid error
   of resource type unknown.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label May 25, 2023
@nunnatsa
Copy link
Contributor Author

/retest

@nunnatsa
Copy link
Contributor Author

/test e2e-kubevirt-aws-ovn

1 similar comment
@nunnatsa
Copy link
Contributor Author

/test e2e-kubevirt-aws-ovn

davidvossel
davidvossel reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3b73a1a and 2 for PR HEAD 5e33478 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks 5e33478 link false /test e2e-ibmcloud-roks
ci/prow/e2e-ibmcloud-iks 5e33478 link false /test e2e-ibmcloud-iks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 874b634 into openshift:main May 25, 2023
12 of 14 checks passed
@nunnatsa nunnatsa deleted the fix-kv-dump branch May 26, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel left review comments

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@davidvossel davidvossel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nunnatsa @davidvossel @openshift-ci-robot @openshift-merge-robot