Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1009: Allow external-dns image to be set in install cli #2623

Merged
merged 1 commit into from Jun 2, 2023
Merged

HOSTEDCP-1009: Allow external-dns image to be set in install cli #2623

merged 1 commit into from Jun 2, 2023

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
Allow the external-dns image to be set in the install cli through the external-dns-image flag.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1009

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 30, 2023 •
edited by openshift-ci bot

@bryan-cox: This pull request references HOSTEDCP-1009 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Allow the external-dns image to be set in the install cli through the external-dns-image flag.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1009

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/needs-area do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels May 30, 2023
@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox bryan-cox marked this pull request as ready for review May 30, 2023 19:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2023
@openshift-ci openshift-ci bot requested review from enxebre and sjenning May 30, 2023 19:59
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023
jparrill
jparrill reviewed May 31, 2023
View reviewed changes
cmd/install/install.go Outdated Show resolved Hide resolved
hack/app-sre/saas_template.yaml Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023
@netlify
Copy link

netlify bot commented May 31, 2023 •
edited

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 32ec8bf
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/64778abd974e6a00080a470c
😎 Deploy Preview https://deploy-preview-2623--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bryan-cox
Allow external-dns image to be set in install cli
32ec8bf 
Allow the external-dns image to be set in the install cli through the
external-dns-image flag.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kubevirt-aws-ovn 32ec8bf link false /test e2e-kubevirt-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@muraee
Copy link
Contributor

muraee commented Jun 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@csrwng
Copy link
Contributor

csrwng commented Jun 2, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit 734044c into openshift:main Jun 2, 2023
11 of 12 checks passed
@bryan-cox bryan-cox deleted the HOSTEDCP-1009 branch June 2, 2023 14:51
@bryan-cox
Copy link
Member Author

/cherry-pick release-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 5, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bryan-cox: new pull request created: #2652

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparrill jparrill jparrill left review comments

@enxebre enxebre Awaiting requested review from enxebre

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@muraee muraee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bryan-cox @openshift-ci-robot @muraee @csrwng @openshift-cherrypick-robot @jparrill @openshift-merge-robot