HOSTEDCP-1008: Add NodePoolTransitionSeconds metric #2631
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@muraee: This pull request references HOSTEDCP-1008 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
openshift-ci
bot
added
area/hypershift-operator
observe time in seconds it took from NodePool creation until a given condition transitions to true
muraee
force-pushed
the
nodepool-transitions-metric
branch
from
84da8f5
to
85d2307
Compare
|
/retest-required |
| NodePoolTransitionSecondsMetricName = "hypershift_nodepools_transition_seconds" | ||
| nodePoolTransitionSeconds = prometheus.NewHistogramVec(prometheus.HistogramOpts{ | ||
| Name: NodePoolTransitionSecondsMetricName, | ||
| Help: "Time in seconds it took from NodePool creation until a given condition transitions to true", |
There was a problem hiding this comment.
Do we know the "given condition"? Could this be explained better? I think this ends up in the UI right?
There was a problem hiding this comment.
we are tracking multiple conditions with this metric, each condition will have its own time series with the condition name/type set as a label.
the help won't show in Grafana UI as far as I know.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, enxebre, muraee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@muraee: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.13 |
|
@muraee: new pull request created: #2758 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
records time in seconds it took from NodePool creation until a given condition transitions to true, for the following conditions:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #https://issues.redhat.com/browse/HOSTEDCP-1008
Checklist