Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1060: refactor ignition-server reconcilation #2662

Merged
merged 1 commit into from Jun 8, 2023

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Jun 8, 2023

https://issues.redhat.com/browse/HOSTEDCP-992

No functional change, just refactor to match CPO coding style of a main component level Reconcile with per-resource reconcile functions within the package.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 8, 2023

@sjenning: This pull request references HOSTEDCP-992 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/HOSTEDCP-992

No functional change, just refactor to match CPO coding style of a main component level Reconcile with per-resource reconcile functions within the package.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 8, 2023
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Jun 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jun 8, 2023
@enxebre
Copy link
Member

enxebre commented Jun 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sjenning
Copy link
Contributor Author

sjenning commented Jun 8, 2023

/override "Red Hat Trusted App Pipeline / hypershift-operator-main-on-pull-request"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

@sjenning: Overrode contexts on behalf of sjenning: Red Hat Trusted App Pipeline / hypershift-operator-main-on-pull-request

In response to this:

/override "Red Hat Trusted App Pipeline / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d0eb8d8 into openshift:main Jun 8, 2023
12 of 13 checks passed
@sjenning sjenning changed the title HOSTEDCP-992: refactor ignition-server reconcilation HOSTEDCP-1060: refactor ignition-server reconcilation Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants