Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1031: Add Destroy Cluster Cmd for KubeVirt for HCP CLI #2673

Merged
merged 1 commit into from Jun 23, 2023
Merged

HOSTEDCP-1031: Add Destroy Cluster Cmd for KubeVirt for HCP CLI #2673

merged 1 commit into from Jun 23, 2023

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
Add destroy cluster command for the KubeVirt platform for the HCP CLI.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1031

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 9, 2023 •
edited by openshift-ci bot

@bryan-cox: This pull request references HOSTEDCP-1031 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Add destroy cluster command for the KubeVirt platform for the HCP CLI.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1031

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Jun 9, 2023
@bryan-cox
Copy link
Member Author

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2023

@bryan-cox: The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-kubevirt-aws-ovn
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-4-12
  • /test e2e-aws-4-13
  • /test e2e-aws-metrics
  • /test e2e-conformance
  • /test e2e-ibmcloud-iks
  • /test e2e-ibmcloud-roks

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bryan-cox
Copy link
Member Author

/test e2e-aws
/test e2e-kubevirt-aws-ovn

@bryan-cox bryan-cox marked this pull request as ready for review June 20, 2023 16:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2023
@openshift-ci openshift-ci bot requested review from nirarg and sjenning June 20, 2023 16:43
davidvossel
davidvossel reviewed Jun 20, 2023
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

TestUpgradeControlPlane flake
/test e2e-aws

davidvossel
davidvossel reviewed Jun 21, 2023
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2023
@bryan-cox
Add Destroy Cluster Cmd for KubeVirt for HCP CLI
c712671 
Add destroy cluster command for the KubeVirt platform for the HCP CLI.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2023
@csrwng
Copy link
Contributor

csrwng commented Jun 22, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@bryan-cox
Copy link
Member Author

TestUpgradeControlPlane/EnsureNoCrashingPods flake
/test e2e-aws

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 55a2549 and 2 for PR HEAD c712671 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b56d80b and 1 for PR HEAD c712671 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8aaeca4 into openshift:main Jun 23, 2023
12 checks passed
@bryan-cox bryan-cox deleted the HOSTEDCP-1031 branch June 23, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel left review comments

@nirarg nirarg Awaiting requested review from nirarg

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@davidvossel davidvossel

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bryan-cox @openshift-ci-robot @csrwng @davidvossel @openshift-merge-robot