New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOSTEDCP-967: [Re-revert] Disable v1alpha1 and conversion webhook by default #2685
HOSTEDCP-967: [Re-revert] Disable v1alpha1 and conversion webhook by default #2685
Conversation
Disables v1alpha1 and the conversion webhook by default when installing hypershift.
@muraee: This pull request references HOSTEDCP-967 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
1 similar comment
/retest-required |
Can you please add some context in the PR desc for the record on why we went from A -> B -> A -> B |
@muraee: This pull request references HOSTEDCP-967 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@enxebre done |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, muraee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
@muraee: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
reverts #2627
Original PR had to be reverted because an old 4.13 release version
4.13.0-0.nightly-2023-01-17-084735
was being used in our CI which doesn't include the CNO PR openshift/cluster-network-operator#1802 to switch to v1beta1.This has been fixed with openshift/release#39925 so it is safe now to re introduce this change.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist