Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-967: [Re-revert] Disable v1alpha1 and conversion webhook by default #2685

Merged

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Jun 14, 2023

What this PR does / why we need it:
reverts #2627

Original PR had to be reverted because an old 4.13 release version 4.13.0-0.nightly-2023-01-17-084735 was being used in our CI which doesn't include the CNO PR openshift/cluster-network-operator#1802 to switch to v1beta1.
This has been fixed with openshift/release#39925 so it is safe now to re introduce this change.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Disables v1alpha1 and the conversion webhook by default when installing hypershift.
@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Jun 14, 2023
@muraee muraee changed the title Re revert disable v1alpha1 HOSTEDCP-967: [Re-revert] Disable v1alpha1 and conversion webhook by default Jun 14, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 14, 2023

@muraee: This pull request references HOSTEDCP-967 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
reverts #2627

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@muraee
Copy link
Contributor Author

muraee commented Jun 14, 2023

/retest-required

1 similar comment
@muraee
Copy link
Contributor Author

muraee commented Jun 15, 2023

/retest-required

@enxebre
Copy link
Member

enxebre commented Jun 15, 2023

Can you please add some context in the PR desc for the record on why we went from A -> B -> A -> B

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2023

@muraee: This pull request references HOSTEDCP-967 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
reverts #2627

Original PR had to be reverted because an old 4.13 release version 4.13.0-0.nightly-2023-01-17-084735 was being used in our CI which doesn't include the CNO PR openshift/cluster-network-operator#1802 to switch to v1beta1.
This has been fixed with openshift/release#39925 so it is safe now to re introduce this change.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@muraee
Copy link
Contributor Author

muraee commented Jun 15, 2023

@enxebre done

@enxebre
Copy link
Member

enxebre commented Jun 16, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
@imain
Copy link
Contributor

imain commented Jun 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 63110f0 and 2 for PR HEAD 03364cf in total

@enxebre
Copy link
Member

enxebre commented Jun 19, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

@muraee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5e69795 into openshift:main Jun 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants