Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling unused monitoring services #2730

Merged
merged 1 commit into from Oct 14, 2023
Merged

Disabling unused monitoring services #2730

merged 1 commit into from Oct 14, 2023

Conversation

cappetersson
Copy link
Contributor

PR connected to issue: #2679

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2023
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Jun 26, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023
@cappetersson
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023
@cappetersson
Copy link
Contributor Author

/retest

1 similar comment
@cappetersson
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2023
@cappetersson
Copy link
Contributor Author

/retest

1 similar comment
@cappetersson
Copy link
Contributor Author

/retest

csrwng
csrwng reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@csrwng csrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise lgtm

hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Sep 11, 2023 •
edited

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 996ad7a
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/6528529337d1a600082dca03
😎 Deploy Preview https://deploy-preview-2730--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cappetersson cappetersson force-pushed the disable-monitoring-services branch 2 times, most recently from 23affd2 to a41f4e2 Compare September 11, 2023 14:49
@csrwng
Copy link
Contributor

csrwng commented Sep 11, 2023

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@hasueki
Copy link
Contributor

hasueki commented Sep 15, 2023

/retest

2 similar comments
@cappetersson
Copy link
Contributor Author

/retest

@cappetersson
Copy link
Contributor Author

/retest

@cappetersson
Copy link
Contributor Author

/retest

5 similar comments
@cappetersson
Copy link
Contributor Author

/retest

@cappetersson
Copy link
Contributor Author

/retest

@cappetersson
Copy link
Contributor Author

/retest

@cappetersson
Copy link
Contributor Author

/retest

@cappetersson
Copy link
Contributor Author

/retest

@cappetersson
Copy link
Contributor Author

/test create-cluster

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@cappetersson: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-kubevirt-aws-ovn
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-4-12
  • /test e2e-aws-4-13
  • /test e2e-aws-metrics
  • /test e2e-conformance
  • /test e2e-ibmcloud-iks
  • /test e2e-ibmcloud-roks

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-iks
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-roks
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify

In response to this:

/test create-cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cappetersson
Copy link
Contributor Author

/test all

@cappetersson
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023 •
edited

@cappetersson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/arm64-images 7157356 link true /test arm64-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hasueki
hasueki approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@hasueki hasueki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cappetersson, csrwng, hasueki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 6f7f6c1 into openshift:main Oct 14, 2023
14 checks passed
@cappetersson cappetersson deleted the disable-monitoring-services branch October 19, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng csrwng left review comments

@hasueki hasueki hasueki approved these changes

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@hasueki hasueki

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cappetersson @csrwng @hasueki @openshift-merge-robot