Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded AWS CI References #2742

Merged
merged 1 commit into from Jun 30, 2023
Merged

Remove hardcoded AWS CI References #2742

merged 1 commit into from Jun 30, 2023

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Jun 27, 2023

What this PR does / why we need it:

This PR adds flags to the e2e binary so that the hardcoded AWS objects can be removed from the e2e codebase:

  • --e2e.aws-oidc-s3-bucket-name
  • --e2e.aws-kms-key-alias

So that the e2e test can be run accordingly locally after creating the required AWS infrastructure on your own.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@mjlshen mjlshen changed the title Remove hardcoded AWS CI objects Remove hardcoded AWS CI References Jun 27, 2023
@openshift-ci openshift-ci bot requested review from csrwng and sjenning June 27, 2023 20:01
@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Jun 27, 2023
@mjlshen
Copy link
Contributor Author

mjlshen commented Jun 27, 2023

/retest-required

bryan-cox
bryan-cox reviewed Jun 28, 2023
View reviewed changes
HACKING.md Outdated Show resolved Hide resolved
hack/ci-test-e2e.sh Show resolved Hide resolved
test/e2e/e2e_test.go Show resolved Hide resolved
test/e2e/e2e_test.go Show resolved Hide resolved
@mjlshen
Remove hardcoded AWS CI references
4f608c5 
This PR adds flags to the e2e binary so that the hardcoded AWS objects
can be removed from the e2e codebase:

* --e2e.aws-oidc-s3-bucket-name
* --e2e.aws-kms-key-alias

So that the e2e test can be run accordingly locally after creating the
required AWS infrastructure on your own.

Signed-off-by: Michael Shen <mshen@redhat.com>
bryan-cox
bryan-cox approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2023
@mjlshen mjlshen mentioned this pull request Jun 29, 2023
Merged
4 tasks
@csrwng
Copy link
Contributor

csrwng commented Jun 29, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, csrwng, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2023
@mjlshen
Copy link
Contributor Author

mjlshen commented Jun 29, 2023

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 37b4ec7 and 2 for PR HEAD 4f608c5 in total

@mjlshen
Copy link
Contributor Author

mjlshen commented Jun 29, 2023

/retest-required

1 similar comment
@mjlshen
Copy link
Contributor Author

mjlshen commented Jun 30, 2023

/retest-required

@mjlshen
Copy link
Contributor Author

mjlshen commented Jun 30, 2023

/retest

1 similar comment
@mjlshen
Copy link
Contributor Author

mjlshen commented Jun 30, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD faaf1d9 and 1 for PR HEAD 4f608c5 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

@mjlshen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1637548 into openshift:main Jun 30, 2023
12 checks passed
@mjlshen mjlshen deleted the OCPBUGS-14862-e2e branch June 30, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryan-cox bryan-cox bryan-cox approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mjlshen @csrwng @openshift-ci-robot @bryan-cox @openshift-merge-robot