Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-15594: Get valid arch image for cluster-config-operator #2753

Merged
merged 1 commit into from Jul 7, 2023
Merged

OCPBUGS-15594: Get valid arch image for cluster-config-operator #2753

merged 1 commit into from Jul 7, 2023

Conversation

bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented Jun 29, 2023 •
edited

What this PR does / why we need it:
Retrieves the valid image for cluster-config-operator based on the arch of the system.

Which issue(s) this PR fixes:
OCPBUGS-15594

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Jun 29, 2023
@bryan-cox
Copy link
Member Author

/test e2e-aws

1 similar comment
@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox bryan-cox changed the title Get valid arch image for cluster-config-operator OCPBUGS-15594: Get valid arch image for cluster-config-operator Jun 30, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 30, 2023
@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-15594, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
Retrieves the valid image for cluster-config-operator based on the arch of the system.

Which issue(s) this PR fixes:
N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-15594, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

What this PR does / why we need it:
Retrieves the valid image for cluster-config-operator based on the arch of the system.

Which issue(s) this PR fixes:
OCPBUGS-15594

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bryan-cox
Copy link
Member Author

e2e's were previously broken but have been fixed
/test e2e-aws

@bryan-cox bryan-cox force-pushed the fix-cluster-config-operator branch from af85b51 to 74b4c19 Compare June 30, 2023 18:35
@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox bryan-cox marked this pull request as ready for review July 5, 2023 12:16
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@bryan-cox
Get valid arch image for cluster-config-operator
b334984 
Retrieves the valid image for cluster-config-operator based on the arch
of the system.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox bryan-cox force-pushed the fix-cluster-config-operator branch from 74b4c19 to b334984 Compare July 5, 2023 14:58
@enxebre
Copy link
Member

enxebre commented Jul 5, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@muraee
Copy link
Contributor

muraee commented Jul 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 836efe7 and 2 for PR HEAD b334984 in total

@bryan-cox
Copy link
Member Author

e2e-aws-create-management-cluster failed

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4b49f1f and 1 for PR HEAD b334984 in total

@bryan-cox
Copy link
Member Author

/test e2e-aws

1 similar comment
@bryan-cox
Copy link
Member Author

/test e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 24cf680 into openshift:main Jul 7, 2023
12 checks passed
@openshift-ci-robot
Copy link

@bryan-cox: Jira Issue OCPBUGS-15594: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15594 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
Retrieves the valid image for cluster-config-operator based on the arch of the system.

Which issue(s) this PR fixes:
OCPBUGS-15594

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bryan-cox bryan-cox deleted the fix-cluster-config-operator branch July 7, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@muraee muraee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bryan-cox @openshift-ci-robot @enxebre @muraee @openshift-merge-robot