Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1019: Add create cluster for Agent for HCP CLI #2754

Merged
merged 1 commit into from Jul 9, 2023
Merged

HOSTEDCP-1019: Add create cluster for Agent for HCP CLI #2754

merged 1 commit into from Jul 9, 2023

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
Add create cluster for Agent for HCP CLI

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1019

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 29, 2023 •
edited by openshift-ci bot

@bryan-cox: This pull request references HOSTEDCP-1019 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Add create cluster for Agent for HCP CLI

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1019

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Jun 29, 2023
eranco74
eranco74 reviewed Jul 2, 2023
View reviewed changes
Copy link
Contributor

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2023
@avishayt
Copy link
Contributor

avishayt commented Jul 2, 2023

/lgtm

@bryan-cox bryan-cox marked this pull request as ready for review July 5, 2023 12:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@openshift-ci openshift-ci bot requested review from enxebre and sjenning July 5, 2023 12:20
enxebre
enxebre reviewed Jul 5, 2023
View reviewed changes
product-cli/cmd/cluster/agent/create.go Outdated
AgentNamespace: "",
}

cmd.Flags().StringVar(&opts.AgentPlatform.APIServerAddress, "api-server-address", opts.AgentPlatform.APIServerAddress, "The API server address that should be used for components outside the control plane")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything else we can add to make this more clear? what are components outside the control plane?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avishayt @eranco74 - is there anything additional here we can add?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the hosted cluster kubeapi endpoint.
Perhaps
The API server address is the IP address for Kubernetes API communication.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@netlify
Copy link

netlify bot commented Jul 6, 2023

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit d4f7349
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/64a6a941aef7ce000830dc61
😎 Deploy Preview https://deploy-preview-2754--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@enxebre
Copy link
Member

enxebre commented Jul 6, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
jparrill
jparrill reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@bryan-cox
Copy link
Member Author

/test e2e-aws

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 24cf680 and 2 for PR HEAD d4f7349 in total

@bryan-cox
Copy link
Member Author

CI was broken previously.
/test e2e-aws

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox
Add create cluster for Agent for HCP CLI
eec10c0 
Signed-off-by: Bryan Cox <brcox@redhat.com>
@eranco74
Copy link
Contributor

eranco74 commented Jul 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 79f2314 and 2 for PR HEAD eec10c0 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2023

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b7af4e4 into openshift:main Jul 9, 2023
12 checks passed
@bryan-cox bryan-cox deleted the HOSTEDCP-1019 branch July 10, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@jparrill jparrill jparrill left review comments

@eranco74 eranco74 eranco74 left review comments

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@jparrill jparrill

@eranco74 eranco74

@avishayt avishayt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bryan-cox @openshift-ci-robot @avishayt @enxebre @eranco74 @jparrill @openshift-merge-robot