Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1023: Add create NodePool for Agent for HCP CLI #2755

Merged
merged 1 commit into from Jul 5, 2023
Merged

HOSTEDCP-1023: Add create NodePool for Agent for HCP CLI #2755

merged 1 commit into from Jul 5, 2023

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
Add create NodePool for Agent for HCP CLI

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1023

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@bryan-cox
Add create NodePool for Agent for HCP CLI
32614b5 
Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 29, 2023 •
edited by openshift-ci bot

@bryan-cox: This pull request references HOSTEDCP-1023 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Add create NodePool for Agent for HCP CLI

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1023

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Jun 29, 2023
eranco74
eranco74 reviewed Jul 2, 2023
View reviewed changes
Copy link
Contributor

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2023
@avishayt
Copy link
Contributor

avishayt commented Jul 2, 2023

Looks good, thanks! The agent nodepool has one property (a label selector) - should we add it here?

@bryan-cox
Copy link
Member Author

Looks good, thanks! The agent nodepool has one property (a label selector) - should we add it here?

We could. I don't see that in the existing command to add an Agent NodePool though. Does it need added there as well?

@bryan-cox bryan-cox marked this pull request as ready for review July 5, 2023 12:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented Jul 5, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7c8b09f into openshift:main Jul 5, 2023
12 checks passed
@bryan-cox bryan-cox deleted the HOSTEDCP-1023 branch July 5, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranco74 eranco74 eranco74 left review comments

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@eranco74 eranco74

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bryan-cox @openshift-ci-robot @avishayt @enxebre @eranco74 @openshift-merge-robot