Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-14862 Improve clarity around hypershift operator permissions #2810

Merged
merged 1 commit into from Jul 17, 2023
Merged

[release-4.13] OCPBUGS-14862 Improve clarity around hypershift operator permissions #2810

merged 1 commit into from Jul 17, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2782

/assign csrwng

@mjlshen
Improve clarity around hypershift operator permissions
edae8f7 
* The operator now expects to be able to perform
  ec2:RejectVpcEndpointConnections
* The message of AWS errors is logged, which can help identify which
  AWS operation is running into errors.

Signed-off-by: Michael Shen <mshen@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 12, 2023
Merged
4 tasks
@openshift-ci openshift-ci bot requested review from csrwng and sjenning July 12, 2023 22:59
@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Jul 12, 2023
@mjlshen
Copy link
Contributor

mjlshen commented Jul 13, 2023

/retest

4 similar comments
@mjlshen
Copy link
Contributor

mjlshen commented Jul 14, 2023

/retest

@mjlshen
Copy link
Contributor

mjlshen commented Jul 14, 2023

/retest

@mjlshen
Copy link
Contributor

mjlshen commented Jul 15, 2023

/retest

@mjlshen
Copy link
Contributor

mjlshen commented Jul 15, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bryan-cox
bryan-cox approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@enxebre
Copy link
Member

enxebre commented Jul 17, 2023

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@openshift-merge-robot openshift-merge-robot merged commit 263a080 into openshift:release-4.13 Jul 17, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryan-cox bryan-cox bryan-cox approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@enxebre enxebre

@csrwng csrwng

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @mjlshen @enxebre @bryan-cox @csrwng @openshift-merge-robot